-
-
Notifications
You must be signed in to change notification settings - Fork 502
London | 26-ITP-May | Shahriar Ahmed | Sprint 2 | Wireframe #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 17 commits
181e129
cfc6da1
4220f42
0622f5b
9e75111
5274f8c
2db891e
ea8cbac
a614aa1
c420342
ad87d4b
218c5d8
186465d
489efb3
4c9a14e
5ecd965
f77d3db
c6f6616
6f42afd
b09efa0
8926a19
e60b5ba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,23 +10,39 @@ | |
| <header> | ||
| <h1>Wireframe</h1> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| What is a readme file for or what is the purpose of a wireframe and what is a git branch?<br> | ||
| Read below to find out! | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <img src="readme.png" alt="" /> | ||
| <h2>What is a readme file?</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| A readme file informs anyone looking at your repository what your project is about. It lets them know how to install it (if its an application) and how to use it. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| <a href="https://github.com/hedge-dev/UnleashedRecomp">Read more</a> | ||
| </article> | ||
| <article> | ||
| <img src="wireframe.png" alt=""> | ||
| <h2>What is the purpose of a Wireframe?</h2> | ||
| <p> | ||
| The purpose of a wireframe is to provide visual understanding for a web page layout. In other words, it shows the layout of webpage so clients can sign off on the layout before any extra creative work goes into it. | ||
| </p> | ||
| <a href="https://www.figma.com/resource-library/what-is-wireframing/">Read more</a> | ||
| </article> | ||
| <article> | ||
| <img src="images.png" alt=""> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images Can you give a more descriptive alt value to the images?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for pointing that out, I forgot to add that and I have done so now. |
||
| <h2>What is a branch in Git?</h2> | ||
| <p> | ||
| A branch in Git is like a seperate workspace that is contained within the project where any changes made won't affect the main repository. | ||
| </p> | ||
| <a href="https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell#:~:text=A%20branch%20in%20Git%20is,Note">Read more</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| <p class="footer__p"> | ||
| Shahriar Ahmed's sprint 2 wireframe backlog. | ||
| </p> | ||
| </footer> | ||
| </body> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,8 @@ body { | |
| background: var(--paper); | ||
| color: var(--ink); | ||
| font: var(--font); | ||
| box-sizing: border-box; | ||
| margin: 0; | ||
| } | ||
| a { | ||
| padding: var(--space); | ||
|
|
@@ -39,20 +41,28 @@ a { | |
| img, | ||
| svg { | ||
| width: 100%; | ||
| object-fit: cover; | ||
| } | ||
| /* ====== Site Layout ====== | ||
| Setting the overall rules for page regions | ||
| https://www.w3.org/WAI/tutorials/page-structure/regions/ | ||
| */ | ||
|
|
||
| header { | ||
| text-align: center; | ||
| } | ||
|
|
||
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
| text-align: center; | ||
| width: 100%; | ||
| box-sizing: border-box; | ||
| border: 1px, solid, black; | ||
| } | ||
|
Comment on lines
60
to
66
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a syntax error in this block of code. Can you fix it? While https://jigsaw.w3.org/css-validator/ does not work when CSS code contains variables or nested selectors, we can still use it to check the syntax of a single block of CSS code. Alternatively, you can feed your code to an AI tool to ask it to check for errors or possible improvement.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see now, there should be no commas within the border attribute |
||
| /* ====== Articles Grid Layout ==== | ||
| Setting the rules for how articles are placed in the main element. | ||
|
|
@@ -69,6 +79,7 @@ main { | |
| grid-column: span 2; | ||
| } | ||
| } | ||
|
|
||
| /* ====== Article Layout ====== | ||
| Setting the rules for how elements are placed in the article. | ||
| Now laying out just the INSIDE of the repeated card/article design. | ||
|
|
@@ -85,5 +96,10 @@ article { | |
| } | ||
| > img { | ||
| grid-column: span 3; | ||
| aspect-ratio: 16/9; | ||
| } | ||
| } | ||
|
|
||
| .footer__p { | ||
| text-align: center; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking HTML text into multiple lines helps make the code easier to read, edit, and maintain while preserving the same rendered output.
VS Code formatter could be used to keep our code consistently formatted, including breaking long
lines of HTML text into multiple lines for easier editing and maintenance.
As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.
Please note that code formatters may not work correctly when the source code contains syntax errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have followed the guide and set it up correctly now. I was wondering why prettier wasn't working correctly.