Skip to content

Commit 88db0dc

Browse files
committed
fix the indentation and also fix getCardValue based on the comment
1 parent 0b7c108 commit 88db0dc

2 files changed

Lines changed: 19 additions & 32 deletions

File tree

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

Lines changed: 18 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -16,29 +16,18 @@
1616

1717
function getAngleType(angle) {
1818
// TODO: Implement this function
19-
if (angle>0 && angle<90)
20-
{
21-
return "Acute angle";
22-
}
23-
else if (angle==90)
24-
{
25-
return "Right angle";
26-
}
27-
else if (angle>90 && angle<180)
28-
{
19+
if (angle > 0 && angle < 90) {
20+
return "Acute angle";
21+
} else if (angle == 90) {
22+
return "Right angle";
23+
} else if (angle > 90 && angle < 180) {
2924
return "Obtuse angle";
30-
}
31-
else if (angle==180)
32-
{
25+
} else if (angle == 180) {
3326
return "Straight angle";
34-
}
35-
else if (angle>180 && angle<360)
36-
{
27+
} else if (angle > 180 && angle < 360) {
3728
return "Reflex angle";
38-
}
39-
else
40-
{
41-
return "Invalid angle";
29+
} else {
30+
return "Invalid angle";
4231
}
4332
}
4433

@@ -61,28 +50,28 @@ const right = getAngleType(90);
6150
assertEquals(right, "Right angle");
6251

6352
const acute = getAngleType(1);
64-
assertEquals(acute,"Acute angle");
53+
assertEquals(acute, "Acute angle");
6554

6655
const obtuse = getAngleType(90.5);
67-
assertEquals(obtuse,"Obtuse angle");
56+
assertEquals(obtuse, "Obtuse angle");
6857

6958
const straight = getAngleType(180);
70-
assertEquals(straight,"Straight angle");
59+
assertEquals(straight, "Straight angle");
7160

7261
const reflex = getAngleType(359.9);
73-
assertEquals(reflex,"Reflex angle");
62+
assertEquals(reflex, "Reflex angle");
7463

7564
const invalid = getAngleType(380);
76-
assertEquals(invalid,"Invalid angle");
65+
assertEquals(invalid, "Invalid angle");
7766

7867
const straight2 = getAngleType(180);
79-
assertEquals(straight2,"Straight angle");
68+
assertEquals(straight2, "Straight angle");
8069

8170
const invalid2 = getAngleType(360);
82-
assertEquals(invalid2,"Invalid angle");
71+
assertEquals(invalid2, "Invalid angle");
8372

8473
const acute2 = getAngleType(0.1);
85-
assertEquals(acute2,"Acute angle");
74+
assertEquals(acute2, "Acute angle");
8675

8776
const invalid3 = getAngleType(0);
88-
assertEquals(invalid3,"Invalid angle");
77+
assertEquals(invalid3, "Invalid angle");

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ function getCardValue(card) {
4545
}
4646

4747
const numvalue = Number(value);
48-
if (numvalue >= 2 && numvalue <= 10) {
49-
return numvalue;
50-
}
48+
return numvalue;
5149
}
5250

5351
// The line below allows us to load the getCardValue function into tests in other files.

0 commit comments

Comments
 (0)