Add Shaders/SharedData constant buffer and sampler strings - #40
Open
Crauzer wants to merge 1 commit into
Open
Conversation
Contributor
|
I was able to find the remaining entry paths: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assets/shaders/shareddata.binholds oneX3DSharedDataindex plus 33 definition entries: 25X3DSharedConstantBufferDefand 8X3DSharedSamplerDef. Every one of those entry keys is currently unresolved, and every definition carries its ownnamestring:Two path schemes reproduce 28 of the 33 keys:
{leaf}is thenamefield with a trailingCBor_BUFFERremoved, in the casing the file itself ships:BonesCB->Bones,PerFramePixelCB->PerFramePixel,IBL_CUBEMAP_SCALES_BUFFER->IBL_CUBEMAP_SCALES. Names with no such suffix are used as is.The flat
Shaders/SharedData/{leaf}entries are now stale against shipped files so this fixes it.Five constant buffers remain unresolved because their path leaf is not a simple transform of
name:CharacterPerDrawVertexCB(0xa61a3acb),PostEffectPixelCB(0xb2db15bc),FontVertexCB(0xcb07a94b),VFXDynamicPerParticleInstanceCBVS(0xd234e251),VFXDynamicPerParticleInstanceCBPS(0xd243ecdb).This work was done with the help of an LLM, and every entry was verified against shipped game data.