fix(quality): the psalm and phpmd findings my container refactor introduced

[rubenvdlinde]

Why

The development push run for #3532 went red on PHP Quality (psalm) and PHP Quality (phpmd). Both findings are mine. psalm was green on the five commits before that merge and red on it.

Both were invisible to #3532's own checks because that PR ran psalm and phpmd per touched file rather than over the tree, and the findings only exist at tree scope.

psalm, five errors

Four are UnusedBaselineEntry: twenty baselined UnusedParam entries across DestructionCheckJob, DestructionExecutionJob, DeckCardService and DeckLinkService that the refactor made unnecessary, because those parameters are used now. Removed from psalm-baseline.xml.

The fifth is UndefinedClass for \OC_App::loadApp() in ImportHandler. The call predates this work, but psalm never reached it: the enclosing branch was only reachable through a container lookup psalm could not type, and injecting IAppManager made the branch analysable. OC_App is a Nextcloud server internal with no OCP equivalent for loadApp(), and it exists whenever that branch can run. Suppressed on the method docblock with the reason, which is the pattern the repo already uses for SecurityException and Transliterator.

UnusedBaselineEntry only ever appears on a full psalm run. A per-file run cannot produce it, because psalm has to see the whole baseline used up before it can call an entry extra. That is why #3532 was green locally and red on CI.

phpmd, one error

SearchTrailMapper crossed the 1000-line ExcessiveClassLength threshold, at 1015. It gained clearAllLogs() in #3532 because the admin endpoint had always called that method and it never existed, so the endpoint threw an \Error for an undefined method. Suppressed with that reason, the idiom 74 other classes in this repo already use, rather than adding a baseline entry.

Verified locally

Check	Result
psalm --memory-limit=2G, full tree	No errors found, exit 0
phpmd lib both rulesets, with baseline	exit 0, no output
phpcs --standard=phpcs.xml on both touched files	exit 0
phpunit tests/Unit --no-coverage	19,454 tests, exit 0, peak 454 MB

🤖 Generated with Claude Code

[github-actions]

Quality Report — ConductionNL/openregister @ 7bcd29f

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-specs		✅
test-l10n		✅
test-l10n-parity		✅
format		✅
check-schema-l10n		✅
check-l10n-js		✅
composer			✅	✅ 174/174
npm			✅	✅ 543/543
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					❌
Newman					✅
Playwright					⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates					✅

---

Quality workflow — 2026-09-08 10:22 UTC

Download the full PDF report from the workflow artifacts.