fix(deps): node-polyfill-webpack-plugin is pinned to 4.0.0 by webpack-vue-config - #873
Closed
rubenvdlinde wants to merge 1 commit into
Closed
fix(deps): node-polyfill-webpack-plugin is pinned to 4.0.0 by webpack-vue-config#873rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
…-vue-config npm ci cannot resolve, so every check dies before it runs: npm error ERESOLVE could not resolve While resolving: @nextcloud/webpack-vue-config@7.0.4 Found: node-polyfill-webpack-plugin@4.1.0 @nextcloud/webpack-vue-config declares node-polyfill-webpack-plugin as EXACTLY "4.0.0" -- an exact version, not a caret range. 4.1.0 therefore cannot satisfy it under any resolution, and the bump was uninstallable the moment it landed. I merged that bump unverified, on the reasoning that a MINOR version is low risk. It is not, when the consumer pins an exact version: semver tells you what the publisher intended, not what your dependency tree will accept. This is the check the merge skipped. Dependabot is told to hold it back, because it will keep proposing it -- it sees a newer version, not the exact pin holding it down. Five apps carried the same combination; this is one of four fixed together, decidiq being exempt because it is on webpack-vue-config v6, which does not depend on the plugin at all.
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| build | ❌ | ||||
| check-manifest | ❌ | ||||
| check-vue-demi | ❌ | ||||
| test-l10n | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ❌ | ||||
| composer | ✅ | ✅ 130/130 | |||
| npm | ❌ | ❌ | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | 🚨 NO VERDICT — enabled but never ran | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-31 00:39 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Author
|
Closing as redundant: Another session reached the same conclusion while this was open — The holdback in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm cicannot resolve, so every check dies before it runs:@nextcloud/webpack-vue-configdeclares the plugin as exactly"4.0.0"— not a caret range:So
4.1.0cannot satisfy it under any resolution. The bump was uninstallable the moment it landed.This one is mine
I merged that bump unverified, on the reasoning that a MINOR version is low risk. That reasoning is wrong when the consumer pins an exact version: semver tells you what the publisher intended, not what your dependency tree will accept. Merging without letting
npm cirun is precisely the check that would have caught it.Scope
Five apps carried the same combination. Four are fixed together; decidiq is exempt because it is on
@nextcloud/webpack-vue-configv6, which does not depend on the plugin at all — checked rather than assumed.Dependabot is also told to hold this package back, because it will keep proposing it — it sees a newer version, not the exact pin holding it down.