fix(deps): resolve the peer chain so npm ci works - #874
Merged
Conversation
npm ci failed with ERESOLVE, so every frontend job failed before running a single check. Majors had landed WITHOUT the peers that must move with them. These packages are a set: bumping one alone leaves another declaring a range the new version cannot satisfy, and npm rejects the whole tree rather than the single package. Fixing them one at a time simply walks the list, because each correction exposes the next conflict underneath -- which is exactly what happened here before the whole set was taken together. Realigned: postcss-html=^1.8.1 node-polyfill-webpack-plugin=4.0.0 stylelint-config-html=^1.1.0 Verified: the lockfile resolves from a clean tree, where it previously exited on ERESOLVE.
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 130/130 | |||
| npm | ✅ | ✅ 711/711 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | 🚨 NO VERDICT — enabled but never ran | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-31 00:48 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm cifailed with ERESOLVE, so every frontend job failed before running a single check.Majors had landed without the peers that must move with them. These packages are a set: bumping one alone leaves another declaring a range the new version cannot satisfy, and npm rejects the whole tree rather than the single package.
Fixing them one at a time simply walks the list — each correction exposes the next conflict underneath. That happened three times here before the whole set was taken together:
That third one is why reverting
postcss-htmlalone did not work: the v2 line was being pulled in by a package I had left alone.Two things worth recording
@nextcloud/webpack-vue-configpins an entire build toolchain, not a couple of packages — babel-loader, css-loader, sass, sass-loader, style-loader, ts-loader, webpack, webpack-cli, webpack-dev-server and node-polyfill — several at exact versions rather than ranges.The pinned version differs by minor, not just major.
6.0.1pins node-polyfill3.0.0;6.3.2pins4.0.0. A rule of thumb based on the major is wrong.Every range here is the one npm itself demanded in the ERESOLVE it reported, not a version chosen by hand.
Verified: the lockfile resolves from a clean tree, where it previously exited on ERESOLVE.