feat: add read-only Actions queue health evidence - #1150
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📝 WalkthroughWalkthrough시간별 GitHub Actions 큐 상태 수집 기능을 추가했습니다. 허용 저장소의 실행과 작업을 읽기 전용으로 조회하고, 실행 상태와 queue-age SLO를 분류합니다. 결과를 JSON·HTML 아티팩트로 저장하며, 워크플로 계약과 처리 경로를 테스트합니다. ChangesActions Queue Health
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: 🟡 Moderate · up to The new scheduled read-only queue-health collector can remain stuck on an unresponsive GitHub API call and occupy the workflow for up to its platform limit, delaying later runs; bounded API and job timeouts should be added before merge, with several smaller validation and robustness follow-ups remaining. Sequence Diagram(s)sequenceDiagram
participant Scheduler as GitHub Actions scheduler
participant Workflow as actions-queue-health.yml
participant Script as actions_queue_health.py
participant GitHub as GitHub API
participant Artifact as Actions artifacts
Scheduler->>Workflow: 매시간 collect 작업 실행
Workflow->>Script: allowlist와 토큰으로 수집 시작
Script->>GitHub: 저장소·PR·실행·작업 읽기 요청
GitHub-->>Script: 큐 및 runner 상태 반환
Script-->>Workflow: JSON·HTML 보고서 생성
Workflow->>Artifact: 실행별 보고서 업로드
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Current-main successor for #1142: head |
|
Current-head review request for PR #1150:
Please provide a fresh independent review for this exact head. Protected current-head checks and qualifying approval remain required before merge. |
|
Current-head verification for |
|
@opencode-agent Review exact current head |
c3697b6 to
f92f08e
Compare
|
@opencode-agent Review exact current head f92f08e against main@2cce96f8. Rebased the read-only Actions queue-health evidence onto current main; allowlisted repositories, bounded pagination/identity retries, named read credentials, and no write/dispatch/merge permissions are preserved. Verified: 76 queue-health/commercial-readiness tests, actionlint, compileall, interrogate, ruff, and git diff --check passed. |
|
Exact-head ecosystem review requested. Verify the current source and checks only; preserve protected gates and read-only credential boundaries. @opencode-agent review |
|
@opencode-agent Review the current exact head of the read-only Actions queue-health successor. Verify complete bounded pagination, exact pull-request/head identity, transient incomplete-response retry, runner-assignment and queue-age classification, deterministic JSON/accessible HTML, and the absence of cancellation, dispatch, branch, merge, or credential-expansion authority. Reacquire exact-head quality, security, CodeQL, SAST, dependency/SBOM, and formal review evidence. Do not alter the branch. |
|
Current exact head The read-only queue-health collector bounds Actions workflow-run responses to 50 records per page, rejects path-traversal repository segments, retries one transient incomplete PR identity response after a bounded delay, records repository-scoped collection failures as explicit incomplete evidence, rejects duplicate repositories, applies a 30-second API subprocess timeout, and has a 30-minute workflow ceiling. It never cancels runs, changes branches, dispatches workflows, or mutates merge state. Systematic RED → GREEN:
Exact-head hosted evidence:
The eight security/SBOM/CodeQL runs and a qualifying exact-head formal Reviews API verdict remain non-passing prerequisites. |
|
Exact current head evidence for
Please review and evaluate Checks against this exact SHA only. No self-approval or predecessor-head evidence transfer. |
|
Final exact current head is now |
|
Correction to my immediately preceding comment: the exact final HEAD is |
|
@opencode-agent Please perform the independent review on exact current head |
|
Exact-head update: remote Agent advanced this PR to 4467d5a after the 7bbd133 evidence. The new commit only completes test docstrings; focused queue-health tests pass (51 passed), interrogate scripts/ci is 100%, compileall and diff check pass. Please review this current HEAD; prior reviews and Checks for 7bbd133 are not current-head approval/evidence. |
|
@opencode-agent please review exact current head 4467d5a. Revalidate the protected current-head review/coverage evidence and report only findings that remain valid on this SHA. |
|
Inkspan exposes a current acceptance hole in this existing #712 owner lane; no Inkspan-local workflow/source mutation is correct. Fresh owner binding before this note: That omission is now a falsifiable operational defect for #712 because Inkspan currently reproduces the queue-starvation split on multiple independent exact heads while native CI obtains runners:
First causal boundary: #1150 cannot emit the machine-readable repository/PR/head/run/job/queue-age/runner-assignment evidence required by #712 for Inkspan because Inkspan is not in its governed target set. Re-running or perturbing these clean consumer heads would not repair that observability gap and would risk replacing the sole current-head required evidence. Smallest owner remedy: add RED acceptance: against current head |
|
Current-head review (2026-08-21):
|
Exact-head restack verification
The stale-base PR was normally advanced by merging current main into the live branch; the only merge conflict was CHANGELOG.md, and both the queue-health and current-main entries were preserved. GitHub now reports mergeable=true against current main. Merge-result local evidence:
Hosted exact-head state: 21 Checks remain nonterminal, none has failed, and no formal APPROVED review exists for this exact head. This is normal gate completion work, not D1-D5 deadlock evidence. Do not bypass protection; publish an independent substantive review and wait for terminal required Checks. |
|
@opencode-agent Please review exact head 8fcb9b1 only. Read the queue-health source, workflow, docs, and tests after the current-main merge; publish substantive findings or approval against this exact SHA. |
|
Merge-result evidence update for exact head 8fcb9b1: local merge commit parents are af65a69 and 731af58; verified merge-result tree is 0b558e5b95e81660165b4085aadf4c73cc218a8f. The full local suite and quality gates were run on this tree. Hosted Checks remain nonterminal and no exact-head approval exists, so this is not merge authorization. |
|
ScopeWeave supplies a current downstream queue-health reproduction for this existing owner path. This is evidence only; no Freshly observed exact ScopeWeave heads and repository-native workflow states:
First failing boundary: unrelated workflow IDs on multiple independent current PR heads do not progress beyond scheduler admission/assignment, so no job/test/source failure is yet available. The repeated cross-workflow shape makes a workflow-specific ScopeWeave source defect less plausible than scheduler/runner/organization capacity or queue-control state. Please use this as a RED fixture/acceptance case for the existing read-only queue-health collector: the report should bind each run to repository + PR + exact head, record queue age and runner/job-assignment evidence, classify current-head versus obsolete runs, and fail/alert its SLO without treating queued evidence as passing. It should also make the next diagnostic boundary explicit (runner unavailable/capacity/concurrency/billing/platform) rather than suggesting source churn or gate weakening. Required GREEN evidence is one coherent current-head report that identifies these runs and distinguishes repo-wide scheduler congestion from a single-workflow failure while remaining read-only. |
Exact-head audit update
Decision remains |
Correction to prior audit commentThe prior comment used an incorrectly expanded SHA for the new commit. Disregard that value. The verified exact current head is:
The live PR head and local |
Exact-head audit
|
Current-head maintenance audit
|
Current-head verification update
|
Current-main successor for #1142. Rebases the read-only Actions queue health evidence onto current main after #1140; retains transient PR identity retries, cross-repository credential fallback, docs, configuration, implementation, and tests. Review and merge this successor only when protected current-head checks and review-thread requirements are satisfied.
Summary by CodeRabbit
새 기능
문서
테스트