fix(opencode): retry OpenCode after coverage blockers clear - #1152
fix(opencode): retry OpenCode after coverage blockers clear#1152seonghobae wants to merge 13 commits into
Conversation
|
Warning Review limit reached
Next review available in: 52 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Current-main successor for #1141: head |
|
Current-head review request for PR #1152:
Please provide a fresh independent review for this exact head. Protected current-head checks and qualifying approval remain required before merge. |
625c5f0 to
199e61e
Compare
|
Current-head correction published at |
|
@opencode-agent Review exact current head |
199e61e to
adfe46d
Compare
|
@opencode-agent Review exact current head adfe46d against main@2cce96f8. Rebased the coverage-blocker retry logic onto current main; it redispatches only after same-head coverage-evidence and Strix completion with no failed checks, while ordinary changes requests remain distinct. Verified: 110 scheduler tests, compileall, interrogate, ruff, and git diff --check passed. |
|
Exact-head ecosystem review requested. Verify the current source and checks only; preserve protected gates and read-only credential boundaries. @opencode-agent review |
|
@opencode-agent Review the current exact head as the sole current-main successor to #1141. Verify that retry eligibility is limited to prior coverage-derived review blockers whose current exact-head coverage evidence has become successful, that unchanged-head idempotency and bounded retry spacing remain intact, and that real source findings, cancelled/incomplete evidence, or non-coverage review blocks cannot be reclassified as retryable success. Reacquire all current-head protected checks and submit the formal review without altering the branch. |
|
@opencode-agent review this exact current HEAD. Use the current commit SHA, current Checks, and current diff; do not reuse prior approvals or prior-head evidence. |
|
Current-head review request for #1152. HEAD: a37fecb This PR fixes the central scheduler's root cause for naruon and other governed repositories: when an exact-head OpenCode review requested changes only because coverage evidence was missing, the scheduler now waits for coverage and Strix to complete successfully, then re-dispatches the same-head OpenCode review. The marker matching is tested against the actual review body, and unrelated change requests remain blocking. Review this exact HEAD with current Checks and active ruleset; do not reuse stale review state. |
|
Please perform an independent review against exact current head a37fecb only. Current read-only inventory: all eight current-head workflow runs completed successfully; no review submission is present. Do not self-approve or transfer predecessor-head evidence; protected merge still requires exact-head approval and terminal Checks. |
|
Remote agents advanced this PR; exact current HEAD is |
|
Correction: the exact current HEAD |
|
Exact current-head review request for |
|
@opencode-agent please review exact current head 77165e6. The earlier predecessor evidence is stale; independently revalidate this SHA for the coverage-review gate and report only current findings. |
|
@opencode-agent Review exact current head |
|
Exact-head audit for SHA 1149106: the coverage-only re-review guard is already corrected in the current tree. coverage_ready calls failed_status_checks with ignore_opencode=True after complete coverage and Strix evidence, so the expected failing prior OpenCode review does not suppress the re-dispatch. No additional change was made. No approval or merge action. |
|
Current-head audit for Devin review comment 3826637826: the reported coverage retry self-block is already fixed at 1149106. The coverage_ready guard calls failed_status_checks(pr, ignore_opencode=True), while unrelated failures remain blocking; the helper docstring and tests cover both the OpenCode-only failure and an unrelated Security Scan failure. Focused scheduler verification passed 3 tests. No code change, approval, or merge is claimed. |
|
Current-head review (2026-08-21):
|
|
Current-head audit for :\n\n- The reported coverage-retry self-block is already fixed in this exact tree: the authenticated coverage-only retry calls , so only the expected prior OpenCode failure is excluded; unrelated failures remain blocking.\n- The exact-head regression covers OpenCode-only failure and unrelated failure.\n- Local verification: ........................................................................ [ 63%] |
|
Correction to the preceding audit comment: inline code formatting was lost by the shell, but the evidence is unchanged. Exact head: 05e95bb. The coverage-only retry calls failed_status_checks(pr, ignore_opencode=True), so only the expected prior OpenCode failure is excluded; unrelated failures remain blocking. The exact-head regression covers OpenCode-only failure and unrelated Security Scan failure. Local verification: 114 scheduler tests passed; Ruff, interrogate 100%, compileall, and git diff --check passed. No source change was needed. Hosted checks are pending for this exact head, and auto-merge remains enabled; protected approval is still required. |
Exact-head review disposition
This bounded scheduler repair only re-dispatches OpenCode after an exact current-head coverage change request, successful Exact-head local evidence:
Hosted exact-head state at observation: 16 checks remain nonterminal and no formal APPROVED review exists for |
Exact-head audit
|
|
Exact-head audit update\n\nObserved hosted CI failure on the prior head: pip-audit lock refresh for PYSEC-2026-3721.\nRoot-cause fix: updated the hash-locked pip dependency to pip 26.2.1 with both package hashes.\n\nExact head: e19066d\nExact base: fce028b\nLocal verification: pip-audit clean and diff checks passed; the lock-only change has no additional local product test delta.\nGitHub mergeability: blocked. Required checks and exact-head approval remain pending; decision remains WAIT_AND_REMEDIATE. |
| for node in status_contexts: | ||
| state = (node.get("state") or "").upper() | ||
| if state in {"FAILURE", "ERROR"}: | ||
| if ignore_opencode and is_opencode_context(node): | ||
| continue |
There was a problem hiding this comment.
🔍 ignore_opencode depends on status-context signal under required-workflow env
When SCHEDULER_REQUIRED_WORKFLOW_REPOSITORY is set, is_opencode_context returns False for every CheckRun, so failed_status_checks(pr, ignore_opencode=True) only skips OpenCode via the opencode-review status context. If a non-authoritative required-workflow OpenCode CheckRun ever concludes with a failing status in that deployment, it would suppress the coverage retry. The tests never set this env var.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
| and review_dispatch_allowed | ||
| and current_head_coverage_change_request(pr) |
There was a problem hiding this comment.
📝 Info: Coverage retry unreachable when the gate posts active threads
The unresolved-thread gate returns before the coverage retry is reached. If the coverage-only change request carries active unresolved review threads, the PR blocks there and the retry never fires. The feature assumes the coverage gate is a summary-only review.
Was this helpful? React with 👍 or 👎 to provide feedback.
Current-head verification update
|
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Current-main successor for #1141. The scheduler re-dispatches OpenCode only when an exact-current-head coverage-only change request is authenticated, coverage and Strix are complete, and every unrelated check is clean.
Exact identity:
11491068712859e936e7ce4ed7f204f5c1157f0cmain@55a8b576725451dfe0a21a57d36a2f1a41619b24TDD evidence:
fb98a07618003aba35f969b71166a2564cf0c5c9: realistic failedopencode-reviewrollup returnedblock; focused suite1 failed, 109 passed.110 passed; full central suite1283 passed, 16 subtests passed.Security Scanstill blocks re-dispatch.git diff --checkpassed.The exception is scoped to the prior OpenCode context inside the authenticated coverage-only retry path; ordinary source findings, failed coverage/Strix, and unrelated failures remain non-passing. Protected checks and an independent exact-head formal verdict remain required.