fix: retain partial visual regions by seonghobae · Pull Request #320 · ContextualWisdomLab/LineageWeave

seonghobae · 2026-08-20T12:44:10Z

Buyer-visible gap

A VISION locator that returned valid salient panels but not full-image coverage
was replaced by one full-image region. Panel coordinates, panel-level OCR, and
panel search attribution were therefore lost.

Change

Retain every valid bounded partial region.
Analyze the parent image once when locator coverage is partial, preserving
evidence outside the panels.
Keep parent-image evidence for empty, invalid, or single full-image locator
output without inventing a region coordinate.
Record the contract in ADR 0104 and add regressions asserting panel
retention, parent analysis, and no fabricated full-image region.

Verification

Current parent fix: keep visual whitespace out of authoritative structure #319:
e84994e9145d3f7a1a7849e94c91de02cccf62fc.
Current head:
0f8bc28f116dc4c6e3a04c01d042de53c51e9173 after an ordinary parent
restack.
uv run --locked --extra dev --extra backend python -m pytest -q —
734 passed, 16 skipped, 4 warnings.
Focused image/normalization tests — 13 passed.
Frontend lint, TypeScript build, 136 tests, production build, Storybook,
actionlint, and git diff --check passed.

No real records, identifiers, or provider credentials are included. This PR
is stacked on #319, which is stacked on #317.

seonghobae · 2026-08-20T12:44:18Z

@opencode-agent review exact current HEAD 34a0c98. Inspect partial visual-region retention, parent-image fallback, region status persistence, and current required Checks. Report actionable findings only; do not approve, bypass, or use stale parent evidence.

coderabbitai · 2026-08-20T12:44:21Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4f42d58a-2474-4335-a2fc-0cdee55ad4a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

seonghobae · 2026-08-20T12:45:12Z

@opencode-agent review exact current HEAD 799671a. Re-check partial visual-region retention, parent-image fallback, region status persistence, and current required Checks. Prior-head evidence is stale; report actionable findings only and do not approve or bypass.

seonghobae · 2026-08-20T12:46:16Z

@opencode-agent review exact current HEAD 41d164c5c0c312b66982f8cf8c4c14f16ab7f80f. Re-check the partial visual-region and parent-failure paths plus current required Checks; prior-head evidence is stale. Report findings only; do not approve or bypass.

seonghobae · 2026-08-20T12:46:29Z

@opencode-agent review exact current HEAD 41d164c. Re-check the partial visual-region and parent-failure paths plus current required Checks; prior-head evidence is stale. Report findings only; do not approve or bypass.

seonghobae · 2026-08-20T17:25:33Z

Review exact current HEAD 41d164c. This is the dependency base for the visual-region validation stack; its required Full test suite and Frontend lint, test, build checks are green. Please publish a formal independent review for this exact SHA and confirm the base-chain relationship before merge.

…mantics' into codex/preserve-partial-image-regions # Conflicts: # docs/product-technical-gap-baseline.md # lineageweave/post_content_normalization.py # tests/test_post_content_normalization.py

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

seonghobae · 2026-08-20T22:28:32Z

Review exact current HEAD 0f8bc28f116dc4c6e3a04c01d042de53c51e9173. Re-check partial visual-region retention, parent-image fallback, region status persistence, and the current required Checks; prior-head evidence is stale. Please publish a formal independent review for this exact SHA and report actionable findings only.

…mantics' into codex/preserve-partial-image-regions

seonghobae · 2026-08-21T00:00:06Z

Reviewed and repaired against exact current head 91a95a976c406a6e9d96c943b74d68e6a1b5cdc7 (including concurrent upstream synchronization commits):

Partial locator regions remain independently described and the original parent image is still described for uncovered content.
A malformed non-iterable locator result now falls back to parent-image evidence instead of incorrectly failing the entire image.
Added a regression test for that provider-boundary case.
Focused verification: uv run --locked --extra dev --extra backend python -m pytest -q tests/test_post_content_normalization.py tests/test_image_content.py tests/test_post_content_persistence_edges.py → 51 passed.
git diff --check passes.

PR #324 remains the stacked follow-up for finite/in-bounds region validation. This PR remains blocked pending independent formal review and terminal Checks; no bypass used.

…mantics' into codex/preserve-partial-image-regions

…mantics' into codex/review-pr320 # Conflicts: # docs/adr/0104-partial-visual-regions-retain-parent-evidence.md # docs/product-technical-gap-baseline.md # lineageweave/post_content_normalization.py # tests/test_post_content_normalization.py

* fix: reject unbounded visual locator regions * docs: refresh exact-head product gap audit * test: cover visual region fallback branches * fix: fall back from malformed visual locator output * docs: refresh visual locator exact-head evidence * test: keep invalid locator fallback coordinate-free * docs: keep PR 320 status under its checkpoint * docs: refresh PR 324 exact-head evidence * fix: safely handle malformed region locator output * fix: keep internal image instructions out of buyer evidence (#329) * fix: keep internal image instructions out of buyer evidence * fix: protect persisted image region captions * fix: preserve legitimate Korean image captions * docs: allocate unique buyer image ADR number * fix: reject invalid vision region response types * fix: block internal vision destinations * fix: keep provider failures out of buyer errors * feat: trace post processing and Valkey sessions (#345) * feat: trace post processing and valkey sessions * docs: align orchestrator runtime pin * docs: codify telemetry boundary * fix: normalize OTLP trace endpoint * chore: pin orchestrator telemetry fix * fix: keep provider details out of ingestion ledger * fix: propagate W3C trace context to gateway

* fix: separate source whitespace from explicit structure * docs: record source indentation buyer gap * fix: expose unexpected content channel defects * fix: expose recoverable content batch failures * docs: normalize gap baseline headings * fix: retain partial visual regions (#320) * fix: retain partial image regions * docs: record partial image region gap * test: cover partial parent vision failure * fix: safely handle malformed region locator output * style: use deferred region result annotation * docs: reconcile partial-region evidence counts * fix: validate retained visual locator regions (#324) * fix: reject unbounded visual locator regions * docs: refresh exact-head product gap audit * test: cover visual region fallback branches * fix: fall back from malformed visual locator output * docs: refresh visual locator exact-head evidence * test: keep invalid locator fallback coordinate-free * docs: keep PR 320 status under its checkpoint * docs: refresh PR 324 exact-head evidence * fix: safely handle malformed region locator output * fix: keep internal image instructions out of buyer evidence (#329) * fix: keep internal image instructions out of buyer evidence * fix: protect persisted image region captions * fix: preserve legitimate Korean image captions * docs: allocate unique buyer image ADR number * fix: reject invalid vision region response types * fix: block internal vision destinations * fix: keep provider failures out of buyer errors * feat: trace post processing and Valkey sessions (#345) * feat: trace post processing and valkey sessions * docs: align orchestrator runtime pin * docs: codify telemetry boundary * fix: normalize OTLP trace endpoint * chore: pin orchestrator telemetry fix * fix: keep provider details out of ingestion ledger * fix: propagate W3C trace context to gateway

devin-ai-integration

Devin Review found 3 new potential issues.

devin-ai-integration · 2026-08-21T09:12:22Z

+    except Exception as exc:  # noqa: BLE001 - provider boundary is fail-closed.
+        raise HTTPException(
+            status.HTTP_503_SERVICE_UNAVAILABLE,
+            "Post chat is unavailable: contextual-orchestrator returned no complete evidence object",
+        ) from exc


🟡 Duplicate unreachable exception handler

A second except Exception as exc: immediately follows an identical catch-all handler, so it is unreachable dead code. The first handler already catches every exception. This looks like an accidental duplication from a restack and can trip linters.

Suggested change

except Exception as exc: # noqa: BLE001 - provider boundary is fail-closed.

raise HTTPException(

status.HTTP_503_SERVICE_UNAVAILABLE,

"Post chat is unavailable: contextual-orchestrator returned no complete evidence object",

) from exc

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-21T09:12:24Z

+        hostname = parsed.hostname
+        if not hostname:
+            raise ValueError("vision client URL is missing a hostname")
+        if parsed.username or parsed.password:
+            raise ValueError("vision client URL must not contain user credentials")
+        try:
+            parsed.port
+        except ValueError as exc:
+            raise ValueError("vision client URL has an invalid port") from exc
+        normalized_hostname = hostname.rstrip(".").casefold()
+        if (
+            normalized_hostname in _BLOCKED_VISION_HOSTNAMES
+            or normalized_hostname.endswith(".localhost")
+        ):
+            raise ValueError(
+                "vision client URL points to a private, loopback, link-local, or metadata destination"
+            )
+        try:
+            address = ipaddress.ip_address(hostname)
+        except ValueError:
+            address = None
+        if address is not None and (
+            address.is_private
+            or address.is_loopback
+            or address.is_link_local
+            or address.is_reserved
+            or address.is_multicast
+            or address.is_unspecified
+        ):
+            raise ValueError(
+                "vision client URL points to a private, loopback, link-local, or metadata destination"
+            )


🔍 Vision channel silently disabled for IP-literal orchestrator URLs

The vision client constructor now rejects loopback, private, link-local, reserved, and metadata hosts even under allow_insecure_http=True. Since orchestrator_vision_client catches ValueError and returns NullImageContentClient, an orchestrator configured at 127.0.0.1 or localhost silently loses vision while embedding and adjudication keep working through the same URL. Compose's orchestrator DNS name is unaffected.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-21T09:12:25Z

+    with traced(
+        "lineageweave.valkey.activity_xadd",
+        {"db.system": "redis", "db.operation.name": "xadd", "lineageweave.stream.kind": "activity"},
+    ):
+        return await client.xadd(
+            _stream_key(post_id),
+            _activity_fields(event_type, actor_account_id, summary),
+            maxlen=1000,
+            approximate=True,
+        )


📝 Info: Synchronous span held across await points

traced starts a synchronous current span and wraps awaited Valkey calls (e.g. publish_activity_event awaits client.xadd inside the with). Holding a current span across an await can attach concurrently scheduled tasks to the wrong parent span. Harmless for the current single-producer/reader paths; trace parenting could mislead if concurrency grows.

Was this helpful? React with 👍 or 👎 to provide feedback.

fix: retain partial image regions

34a0c98

docs: record partial image region gap

799671a

test: cover partial parent vision failure

41d164c

This was referenced Aug 20, 2026

fix: validate retained visual locator regions #324

Merged

docs: refresh current product gap and PR gate audit #325

Merged

Merge remote-tracking branch 'origin/codex/normalize-source-indent-se…

0f8bc28

…mantics' into codex/preserve-partial-image-regions # Conflicts: # docs/product-technical-gap-baseline.md # lineageweave/post_content_normalization.py # tests/test_post_content_normalization.py

devin-ai-integration Bot reviewed Aug 20, 2026

View reviewed changes

seonghobae added 3 commits August 21, 2026 08:53

Merge remote-tracking branch 'origin/codex/normalize-source-indent-se…

8bcc6d6

…mantics' into codex/preserve-partial-image-regions

Merge remote-tracking branch 'origin/codex/normalize-source-indent-se…

ba93fd7

…mantics' into codex/preserve-partial-image-regions

fix: safely handle malformed region locator output

91a95a9

seonghobae added 2 commits August 21, 2026 09:41

Merge remote-tracking branch 'origin/codex/normalize-source-indent-se…

acc5976

…mantics' into codex/preserve-partial-image-regions

style: use deferred region result annotation

cf7331a

seonghobae enabled auto-merge (squash) August 21, 2026 05:04

seonghobae added the bug Something isn't working label Aug 21, 2026 — with ChatGPT Codex Connector

This comment was marked as resolved.

Sign in to view

seonghobae added 3 commits August 21, 2026 16:08

docs: reconcile partial-region evidence counts

67fca36

Merge current source-indent base into partial-region docs

c132b8c

seonghobae merged commit 365f253 into codex/normalize-source-indent-semantics Aug 21, 2026
3 of 4 checks passed

devin-ai-integration Bot reviewed Aug 21, 2026

View reviewed changes

Uh oh!

Conversation

seonghobae commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Buyer-visible gap

Change

Verification

Uh oh!

seonghobae commented Aug 20, 2026

Uh oh!

coderabbitai Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

seonghobae commented Aug 20, 2026

Uh oh!

seonghobae commented Aug 20, 2026

Uh oh!

seonghobae commented Aug 20, 2026

Uh oh!

seonghobae commented Aug 20, 2026

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

seonghobae commented Aug 20, 2026

Uh oh!

seonghobae commented Aug 21, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

seonghobae commented Aug 20, 2026 •

edited

Loading

coderabbitai Bot commented Aug 20, 2026 •

edited

Loading