Skip to content

test: preserve post deep links through OIDC - #331

Merged
seonghobae merged 3 commits into
fix/member-locale-bootstrap-racefrom
feat/locale-deep-link-regression
Aug 21, 2026
Merged

test: preserve post deep links through OIDC#331
seonghobae merged 3 commits into
fix/member-locale-bootstrap-racefrom
feat/locale-deep-link-regression

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Buyer outcome

An unauthenticated buyer who opened a post deep link keeps the post query and evidence hash through the OIDC callback, then returns to the intended content instead of the home page.

Change

  • Added the synthetic regression for ?post=...#... preservation.
  • Kept the existing object/serialized-state and storage fallback coverage.
  • Preserved the shared return-URL helper as the single implementation boundary.
  • Recorded the OIDC safety decision and changelog entry.

Exact-head verification

  • Current base: d0e159872147c7d7bd8bbf042c5552041eb44a4a.
  • Current head: 72e842bad482b73974d8ab4f09d2385582c300d6.
  • Focused OIDC suite: 6 passed.
  • Frontend lint, production build, Storybook build, and git diff --check: passed.
  • Synthetic test data only; no credentials or real identities.

Independent exact-head approval and terminal hosted Checks remain required
before merge. Do not self-approve, force-push, or bypass branch protection.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 485897bc-6a4e-45a4-9923-99afa91e0241

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@seonghobae

Copy link
Copy Markdown
Contributor Author

Correction on exact head 18d85bd9c1f4aa83aa7be0562c61a9eeab1f7ca4:

  • restored the pre-existing three OIDC return-url tests unchanged
  • added one fourth synthetic test covering ?post=...#... preservation
  • focused test: 4 passed
  • frontend lint: passed
  • frontend build: passed

The earlier replacement commit remains in history for auditability; the current tree preserves the base test coverage and adds only the new deep-link case. No merge or protection bypass was performed.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Review exact current HEAD 18d85bd9e651f2f1d590bc47da4946e50ec920f3. Focused OIDC suite 4 passed; frontend lint/build/Storybook/actionlint/diff checks passed. Please publish a formal independent review for this exact SHA; prior review targeted a stale commit.

@seonghobae

Copy link
Copy Markdown
Contributor Author

The current exact HEAD 18d85bd9e651f2f1d590bc47da4946e50ec920f3 was rechecked on the current #328 base: OIDC focused suite 4 passed; frontend lint/build/Storybook/actionlint/diff checks passed. Please use this SHA for independent formal review.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Review exact current HEAD 72e842b (base d0e1598):

  • The regression test covers preservation of both the post query and evidence hash through the OIDC callback state path.
  • Full frontend verification: corepack pnpm exec vitest run → 13 files, 134 tests passed.
  • No implementation defect found in this test-only PR. Hosted Checks are queued and formal independent approval is absent; protected merge remains blocked.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Concurrent parent sync advanced #331 to exact head 72e842bad482b73974d8ab4f09d2385582c300d6; local OIDC verification is 6 passed, lint/build/Storybook passed. Please review and rerun hosted checks on this exact head. Independent approval remains required.

@seonghobae
seonghobae enabled auto-merge (squash) August 21, 2026 04:54
@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact head 72e842b was revalidated. Frontend lint passed, 134 tests passed, Vite build passed, and Storybook build passed. Hosted checks and formal approval remain pending; no merge attempted.

@seonghobae seonghobae added the bug Something isn't working label Aug 21, 2026 — with ChatGPT Codex Connector
@seonghobae
seonghobae merged commit fb77eb7 into fix/member-locale-bootstrap-race Aug 21, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant