Skip to content

fix: preserve nested list item semantic units - #348

Merged
seonghobae merged 1 commit into
feat/uiux-standard-guide-v3-restackedfrom
fix/semantic-structure-units
Aug 21, 2026
Merged

fix: preserve nested list item semantic units#348
seonghobae merged 1 commit into
feat/uiux-standard-guide-v3-restackedfrom
fix/semantic-structure-units

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Preserve li ownership when HTML/Word flow blocks such as p or div are nested inside a list item.
  • Keep table-row and footnote precedence unchanged.
  • Retain declared and visible indentation as semantic-unit metadata.

Evidence

  • uv run --frozen --extra dev --extra backend pytest tests/test_chunking.py -q -> 37 passed
  • uv run --with ruff ruff check lineageweave/chunking.py tests/test_chunking.py -> passed
  • python -m compileall -q lineageweave/chunking.py tests/test_chunking.py -> passed

Closes the parser gap described by the source semantic-unit ADR: list-item meaning must survive nested flow markup.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9f1387de-c28b-4edf-8043-314d61b40c32

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head audit (2026-08-21):

  • Exact head: 1384ba250328f5795f8daebba346a54376b9bcaf
  • Exact base: feat/uiux-standard-guide-v3-restacked at dd7156dadf62d5eff79def3aff2108f7d33e7e7d
  • uv run --extra dev --extra backend pytest -q tests/test_chunking.py: 37 passed
  • Ruff, compileall, and git diff --check: passed
  • No additional code change was necessary after tracing _semantic_label through direct, nested, table, and footnote callers.

Merge remains gated: formal independent approval and terminal required Checks are still absent/queued.

@seonghobae
seonghobae enabled auto-merge (squash) August 21, 2026 04:42
@seonghobae seonghobae added the bug Something isn't working label Aug 21, 2026 — with ChatGPT Codex Connector
@seonghobae
seonghobae merged commit 66f12e9 into feat/uiux-standard-guide-v3-restacked Aug 21, 2026
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant