fix: reuse shared Global Ask session storage key (v2.20.2) - #360
Conversation
acceptAnswer and the 409 stale-citation restart wrote or cleared a string-literal sessionStorage key while bootstrap, 404 retry, and logout already used GLOBAL_ASK_SESSION_STORAGE_KEY. A later key rename would desynchronize recovery. Export the constant, use it at every site, and prove a 409 restart rewrites the shared key.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Independent APPROVE is required on exact head |
|
Found and fixed a real stacked-branch gate failure at exact head The parent stack carried duplicate ADR numeric identities Verification: frontend lint, 192 frontend tests, production build, Storybook build, focused documentation hygiene (5 passed), compileall, and diff check passed. The first backend full suite was |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Stale ADR 0112 dependency after rename
The rename of the TEPP-validation ADR from 0112 to 0127 left 0113-project-history-links-in-ask-surfaces.md still reading "Depends on: ADR 0112". Number 0112 is now owned by an unrelated ADR (docs/adr/0112-project-bound-summary-events.md), so the dependency points to the wrong record.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Revalidation complete on exact pushed head |
…euse-v2201' into HEAD
|
Updated the stacked child with a normal merge of parent #357 at Post-merge local revalidation: documentation hygiene |
881ae30
into
feat/ask-authorized-entity-ids-reuse-v2201
…#357) * fix: reuse authorized entity ids on global ask cutoff query The final Global Ask source query already binds the knowledge cutoff as $4. Reuse the materialized authorized_entity_ids list as $1 instead of re-listing the original input, and keep the contract in v2.20.1. * fix: keep stacked ADR identities unique * fix: reuse shared Global Ask session storage key (v2.20.2) (#360) * fix: reuse shared Global Ask session storage key acceptAnswer and the 409 stale-citation restart wrote or cleared a string-literal sessionStorage key while bootstrap, 404 retry, and logout already used GLOBAL_ASK_SESSION_STORAGE_KEY. A later key rename would desynchronize recovery. Export the constant, use it at every site, and prove a 409 restart rewrites the shared key. * fix: keep stacked ADR identities unique
1 participant
Buyer gap
Stacked onto #357 / #342. After a 409 stale-citation restart, Global Ask wrote and cleared a string-literal
sessionStoragekey while bootstrap, 404 retry, and logout already usedGLOBAL_ASK_SESSION_STORAGE_KEY. Those two keys currently match, but a later rename would leave a desynchronized session id and could reuse hidden prior prose.Exact stack
feat/ask-authorized-entity-ids-reuse-v2201at16c8c6a2e1877c3c6c98fbbef94ca873a848e49f(itself stacked on feat: connect Ask answers to canonical project histories (v2.20.0) #3427d2654fb).feat/ask-session-storage-key-v2202.Change
GLOBAL_ASK_SESSION_STORAGE_KEYand use it for bootstrap, persist, 404 retry, 409 restart, and logout.Verification
replaces an invalid saved Ask session...andrestarts a Global Ask session whose citations lost visibility...passed (2 passed, 92 skippedin that filter).python -m compileallandgit diff --checkpassed.COPILOT_GITHUB_TOKENis not used.Hosted required Checks and an independent APPROVE remain the merge gate. Do not self-approve, force-merge, or bypass protection.