feat: persist and explain Event Lineage channel evidence - #387
feat: persist and explain Event Lineage channel evidence#387seonghobae wants to merge 36 commits into
Conversation
Reconstruct already computed per-channel scores, but live Event Lineage collapsed each edge to a fused score. Persist the active signals beside each edge, return them on GET /api/lineage, and disclose exact inferred values in the Buyer DAG.
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (28)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughEvent Lineage가 채널별 점수·가중치·기여도를 저장하고 API와 DAG에 공개합니다. 재구성은 후보 수에 따라 LLM 사용을 제한하며 원자적으로 결과를 교체합니다. 본문 변환기는 각주, 중첩 목록과 Markdown 표를 처리합니다. ChangesEvent Lineage 채널 근거
본문 변환과 표시
Estimated code review effort: 4 (Complex) | ~60 minutes Merge Risk: 🟡 Moderate · up to The PR adds persisted channel evidence and interactive lineage details, but the current head can accept invalid evidence codes, may leave edge controls unavailable to screen-reader users, and retains a reported lint diagnostic; these could cause incorrect displays, accessibility regressions, or failed quality checks, so merge should wait for fixes or explicit owner acceptance. Sequence Diagram(s)sequenceDiagram
participant 관리자
participant LineageAPI
participant LineagePool
participant AdjudicationClient
participant PostgreSQL
관리자->>LineageAPI: POST /api/lineage/rebuild
LineageAPI->>LineagePool: rebuild_lineage_from_pool
LineagePool->>PostgreSQL: 원본 스냅샷 조회
LineagePool->>AdjudicationClient: 후보 쌍 평가
LineagePool->>PostgreSQL: 엣지와 채널 근거 저장
LineageAPI-->>관리자: 재구성 결과 또는 503
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Requesting independent Copilot review on exact head 03c1946. This is not APPROVE. Do not squash-merge without independent exact-head APPROVE plus required success. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Fixed on exact current head 780fd57: restored the 0102 project-bound summary-event migration constant while retaining the new 0105 channel-evidence migration, so the real PostgreSQL schema fixture applies both in dependency order. Exact schema suite: 10 passed. @claude please review this exact head. |
|
Reproduced and fixed a current frontend Checks failure on the exact PR stack.\n\nRoot cause: the unauthenticated render branch mounted AdminPanel with accessToken typed as string but actually undefined, and retained unused OIDC helper imports. That caused TypeScript TS2322 plus oxlint no-unused-vars. The unauthenticated branch now renders only the login screen; the authenticated admin route remains unchanged, and the unused imports are removed.\n\nExact head: cd7044a. Evidence after the concurrent 780fd57 base: server focused tests 20 passed; frontend focused tests 103 passed; lint, TypeScript/Vite build, Storybook build, and git diff --check passed. No approval is asserted; rerun all Checks on this exact head. |
|
@claude Please review exact current head The rebuild adjudication fix is present in the remote Exact-head local validation: |
|
Validated on exact concurrent head. Preserved 2c47b35 and pushed 516cc55. GET /api/lineage now orders rebuild weights from common_lookup_value.display_order with a deterministic code tie-breaker, so buyer-facing and audit output do not depend on PostgreSQL row order. Rebuild and PostgreSQL import continue to pass the configured ContextualOrchestratorAdjudicationClient; no local provider call or fabricated LLM score was added. Targeted lineage/adjudication/import tests: 40 passed. Full Python suite with dev and backend extras: 768 passed, 17 skipped; 4 existing dependency warnings. git diff --check: passed. Please rerun required checks for the new exact head. |
|
@claude Please review exact current head The current ancestry now also orders persisted rebuild weights by the controlled |
|
Reconciled the current review notes on exact head 4faf9a3: (1) channel availability is run-scoped by reconstruct.active_weights, so the stored rebuild profile is uniform by contract; (2) weight_rows now join common_lookup_value and order by display_order plus signal_code, removing PostgreSQL row-order dependence; (3) the administrator rebuild and PostgreSQL import now pass the configured ContextualOrchestratorAdjudicationClient, while an unavailable gateway remains the explicit NullAdjudicationClient three-channel path. No fabricated LLM evidence is emitted. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Exact-head follow-up:
Hosted Checks have restarted for this exact head. This is a review request, not an approval or merge instruction. |
|
@claude Please review exact current head |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Renumber migrations/0105_post_lineage_interval_relation.sql to 0140: 0105 collides with the already-open PR #387's migrations/0105_post_lineage_edge_signal.sql on the same post_lineage_edge table. Update migrate.sh's whitelist, tests/test_schema.py, tests/test_migration_replay.py, backend/tests/test_api.py, and scripts/seed_demo_data.py to match. - Renumber docs/adr/0122-event-lineage-interval-relation.md to 0160: 0122 collides with the already-open PR #383's docs/adr/0122-otel-session-observability.md. Update every in-tree "ADR 0122" cross-reference (AGENTS.md, ARCHITECTURE.md, CLAUDE.md, CHANGELOG.d entry, the migration's SQL comment, and the seed script docstring) to ADR 0160, and note the renumber + collision in the ADR itself (see ContextualWisdomLab/.github#1249). - Drop the unused "Click Contains to open the revised quote." i18n key from all four locale dictionaries and the i18n completeness test's required-keys list -- no component ever rendered it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B5M79L945DMyMs3sg5yJ14
|
@opencode-agent @cwl-noema-review current-head review for Event Lineage channel evidence (issue #274): persist per-edge scores/weights/contributions, disclose them in the DAG, never invent a fused score. Review threads on this head are resolved. This identity cannot self-approve. |
|
@opencode-agent @cwl-noema-review exact-head independent review for Event Lineage channel evidence (issue #274): persist |
|
Exact-head independent review required on Next leverage-order product gap after shared-gate heads land. OpenCode / Strix / Noema on this SHA only. Checks are not blockers. No self-approval. |
|
@opencode-agent @cwl-noema-review exact-head independent review for Next leverage-order product gap after shared-gate heads land. Product threads resolved; any prior OpenCode CHANGES_REQUESTED that is coverage-evidence-only is not a product finding. Checks are not blockers. This identity cannot self-approve. |
|
@opencode-agent @cwl-noema-review exact-head independent review for Next leverage-order product gap after shared-gate heads land. Product threads resolved; any coverage-evidence-only OpenCode CHANGES_REQUESTED is not a product finding. Checks are not blockers. This identity cannot self-approve. |
|
Resolved the remaining independent Validation: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Exact head 3c3bcb5 closes current review gaps: accessible SVG grouping, sorted exports, category-safe lineage signal checks with existing-table replay, and visible-only focus traversal. Real PostgreSQL/backend tests pass 35/35; all 157 frontend tests, lint, build, Ruff I001/RUF022, ShellCheck, sh -n, and diff checks pass. All current review threads are resolved; hosted gates and independent protected review have requeued. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Exact-head review repair: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The login button had regressed to a raw window.location.pathname + window.location.search concat for the OIDC state.returnUrl, dropping the hash fragment and the isSafeReturnUrl validation that returnUrlFromLocation() already provides, and never called rememberOidcReturnUrl() to persist a storage fallback for restoreOidcReturnUrl() in main.tsx's onSigninCallback. Use the shared helpers again, matching the existing recurring-bug pattern already fixed elsewhere in this stack (the admin-panel-on-unauthenticated-branch half of the same class of regression).
# Conflicts: # CHANGELOG.md # backend/app/lineage_ingestion.py # backend/app/main.py # backend/tests/test_api.py # docker/postgres-init/migrate.sh # docs/adr/README.md # docs/storybook-inventory.md # frontend/package.json # frontend/src/LineageDag.stories.tsx # frontend/src/LineageDag.test.tsx # frontend/src/LineageDag.tsx # frontend/src/PostBody.tsx # frontend/src/i18n.test.ts # frontend/src/postBodyDisplay.ts # lineageweave/__init__.py # migrations/0103_tenant_settings.sql # pyproject.toml # tests/test_lineage_ingestion.py # tests/test_schema.py # uv.lock
…migration-replay tests
Post-merge fixes surfaced by full test verification after merging
origin/main into this branch:
- LineageDag's SVG now uses role="group" (this PR's own accessibility
fix for the interactive per-edge evidence buttons), superseding
main's older role="img". Updated the tests that still queried
role="img" for the lineage graph, and switched the ambiguous
getAllByRole("group") assertions to precise `svg[role="group"]`
queries since <details> (added by this PR's channel-evidence panel)
also carries an implicit ARIA group role.
- postBodyDisplay.ts: adopted main's normalizeScriptText for <sup>/<sub>
handling (real Unicode superscripts, later re-rendered by
splitScriptRuns) instead of this PR's older ad hoc "^N" caret
regex, and dropped the bare-marker FOOTNOTE_START heuristic main
had already removed as a false-positive source (a bullet list
starting with "*" was being misread as a footnote). Restored the
FOOTNOTE_START constant only where still needed transitively, then
removed it entirely once isMarkedFootnote (this PR's own
container-aware footnote detection) proved sufficient on its own.
Updated the one test still asserting the old "^1" caret text.
- migrate.sh's replay gate: this PR's test asserted the old explicit
per-file allowlist main had already replaced with ADR 0166's general
four-digit filename pattern. Updated the assertion to check the new
mechanism covers 0103/0174 without individual entries.
- scripts/import_postgresql_posts.py's rebuild_lineage stub now
accepts the llm= keyword this PR's own call site passes.
- lineage_persistence.py: added the missing docstring on the nested
sort_key helper the AST docstring-coverage audit flagged.
Verified: backend `uv run pytest -q` 931 passed / 16 skipped / 0
failed (0:08:37); frontend `pnpm run lint`, `pnpm run build`, and
`pnpm exec vitest run` (245 passed / 245).
| connection so version, weights, and generated-at stay aligned with | ||
| the new graph. | ||
| """ | ||
| spec = lineage_rebuild_spec(edges) |
There was a problem hiding this comment.
🔍 Persisted signal weights ignore estimated fusion weights
persist_lineage_edges calls lineage_rebuild_spec(edges) without weights, so the persisted signal weights are always derived by renormalizing DEFAULT_CHANNEL_WEIGHTS. rebuild_lineage (backend/app/lineage_ingestion.py:246-252) fuses fused_score with the vector from load_estimated_channel_weights. If an anchor method is ever approved, those diverge and channel_signal_rows reconciliation raises, failing the rebuild. Unreachable today because _SUPPORTED_ANCHOR_METHOD_CODES is empty; the estimated weights must be passed through when it is not.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
Implements issue #274 on current
main(v2.14.0). Live Event Lineage no longer collapses a reconstructed connection to a fused score.post_lineage_edge_signalbeside eachpost_lineage_edgerow: score, the normalized active weight actually used, andweight * scorecontribution.asyncpg.executemanyso a full-corpus replacement does not make one database round-trip per row.event_lineage_rebuild+event_lineage_rebuild_channelso reconstruction version, generated-at, and the weight profile cannot silently rewrite historic evidence.lineage_signal_temporal|secondary_key|text|llm, enforced by table-level CHECK constraints. The LLM row is omitted when it did not participate; it is never fabricated.GET /api/lineagereturns additivechannel_evidence(signal_code,signal_label,score,weight,contribution,rank) ordered by contribution, then controlled signal order. ABAC never reveals evidence for an invisible endpoint.This is independent of #264 ontology-path repair, GNB, and unmerged PRs that claim ADR 0119 / 0122 / 0123 and migration 0104. Analysis-run reconstruction stays out of scope.
Head:
6bcd52f1d8b1efb76f160506e15b5fb2cea1dbf4Tests
Latest persistence regression: 23 passed; real PostgreSQL API/schema partition: 110 passed, 6 capability-gated skips.
uv run --extra dev --with asyncpg pytest tests/test_lineage_ingestion.py tests/test_lineage_channel_evidence.py tests/test_schema.py— 35 passed against real PostgreSQL.pnpm test— 157 passed in 14 files; lint and the 454.69 kB production build passed.Ruff I001/RUF022, ShellCheck,
sh -n, andgit diff --checkpassed.Merge gates
Independent exact-head APPROVE required. This request is not APPROVE. Do not squash-merge without independent APPROVE plus exact-head required success. Issues #79 and #87 stay open.
Summary by CodeRabbit
새 기능
버그 수정