Skip to content

feat: name leftover-map unexplained leftover on leftover pairs (v2.12.26) - #535

Merged
seonghobae merged 6 commits into
mainfrom
feat/leftover-map-unexplained-v21226
Aug 24, 2026
Merged

feat: name leftover-map unexplained leftover on leftover pairs (v2.12.26)#535
seonghobae merged 6 commits into
mainfrom
feat/leftover-map-unexplained-v21226

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Buyer next action

After make seed, leftover post–criterion pairs sit above the member list with unexplained leftover U next to leftover-map distance d. Click the pair to open that post. The U badge is omitted when the pair has no complete-case leftover map (fallback rows do not invent unexplained leftover). Never invent leftover score or theta.

A leftover residual R is not the same fact as the leftover the two leftover-map axes do not reconstruct. Unexplained leftover names U = R − R̂ independently of leftover residual and of leftover-map distance. Two-axis reconstruction R̂ = ξ_{1:2} · ζ_{1:2} is computed internally and is not persisted.

Scope (this PR only)

  • ADR 0182 leftover-map unexplained leftover
  • migration 0182 nullable leftover_map_unexplained on leftover pair rows
  • persist/fetch/seed leftover_map_unexplained when complete-case ξ, ζ exist (U = R − R̂; unused axes pad with 0; hidden SVD axes after the second are dropped)
  • frontend U badge + named next action; i18n en/ko/zh/ja/vi
  • rank-3 synthetic residual proves U ≠ R and ≠ leftover_distance and U == R − R̂; leftover_distance stays full-rank Euclidean
  • rank-0 maps store U = 0; fallback omits U
  • do not persist leftover_map_reconstruction
  • release 2.12.26

Independent of leftover stacks already in review

Do not mix into:

Merge contract


Open in Devin Review

….26)

Persist unexplained leftover U = R − R̂ after two-axis Gabriel reconstruction
so a leftover residual is not read as the leftover the map does not reconstruct.
R̂ stays internal and is not persisted. Rank-0 maps store U = 0; fallback pairs
omit U. After make seed, closest and farthest leftover pairs sit above the
member list with U next to leftover-map distance d; click opens that post.

Copy link
Copy Markdown
Contributor Author

Merge contract for exact head 2141a02b9d1d0e14ecfec940936cd24a0980400c:

Requested reviewers stay empty: the only org collaborator is the author, so review cannot be requested from this account.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 47 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d9dbdbf3-3153-49f3-9c4f-4d86667493ed

📥 Commits

Reviewing files that changed from the base of the PR and between eeecd6e and b0ef770.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (27)
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.d/2.12.26-leftover-map-unexplained.md
  • CHANGELOG.md
  • CLAUDE.md
  • backend/app/report_ingestion.py
  • backend/tests/test_api.py
  • docs/adr/0003-fast-mlsirm-report-integration.md
  • docs/adr/0048-persist-lsirm-leftover-pairs.md
  • docs/adr/0049-leftover-pair-report-ui.md
  • docs/adr/0182-leftover-map-unexplained.md
  • frontend/package.json
  • frontend/src/App.test.tsx
  • frontend/src/api.ts
  • frontend/src/components/LeftoverPairList.tsx
  • frontend/src/i18n.test.ts
  • frontend/src/i18n.ts
  • frontend/src/leftoverMapUnexplained.test.ts
  • frontend/src/leftoverMapUnexplained.ts
  • lineageweave/leftover_pairs.py
  • migrations/0182_report_leftover_map_unexplained.sql
  • migrations/rollback/0182_report_leftover_map_unexplained.sql
  • pyproject.toml
  • scripts/seed_demo_data.py
  • tests/test_leftover_pairs.py
  • tests/test_period_report.py
  • tests/test_schema.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Cycle write probe 2026-08-24T07:18+09:00: independent exact-head APPROVE still required. Author will not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Issues #79 and #87 stay open.

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor Author

Cycle write probe 2026-08-24T07:35+09:00: leftover-map unexplained leftover (#535) stays independent. Next unique leftover honesty slice is unexplained share of centered leftover (s = U_c² / R̃², ADR 0183) on a fresh branch from main@ef6f5a5 — not mixed into this PR. Devin’s grand-mean-in-U note is addressed there by centering, not by patching this head. Author will not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Issues #79 and #87 stay open.

…el render

Login screen built returnUrl via raw string concatenation instead of
returnUrlFromLocation()/rememberOidcReturnUrl(), leaving both imports
unused (TS6192) and rendering an AdminPanel with accessToken: undefined
(TS2322) on a branch guarded by !auth.isAuthenticated.
…xplained-v21226-local

# Conflicts:
#	AGENTS.md
#	ARCHITECTURE.md
#	CHANGELOG.md
#	CLAUDE.md
#	backend/app/report_ingestion.py
#	backend/tests/test_api.py
#	docker/postgres-init/migrate.sh
#	docs/adr/0048-persist-lsirm-leftover-pairs.md
#	docs/adr/0049-leftover-pair-report-ui.md
#	frontend/package.json
#	frontend/src/App.test.tsx
#	frontend/src/App.tsx
#	frontend/src/api.ts
#	frontend/src/i18n.test.ts
#	frontend/src/i18n.ts
#	lineageweave/leftover_pairs.py
#	pyproject.toml
#	scripts/seed_demo_data.py
#	tests/test_leftover_pairs.py
#	tests/test_migration_replay.py
#	tests/test_period_report.py
#	tests/test_schema.py
#	uv.lock
@seonghobae
seonghobae enabled auto-merge August 24, 2026 06:17
opencode-agent Bot and others added 3 commits August 24, 2026 07:14
# Conflicts:
#	AGENTS.md
#	ARCHITECTURE.md
#	CHANGELOG.md
#	CLAUDE.md
#	backend/tests/test_api.py
#	docs/adr/0003-fast-mlsirm-report-integration.md
#	frontend/package.json
#	lineageweave/leftover_pairs.py
#	pyproject.toml
#	tests/test_leftover_pairs.py
#	tests/test_period_report.py
#	tests/test_schema.py
#	uv.lock
@seonghobae
seonghobae merged commit 78c80c9 into main Aug 24, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant