fix(frontend): remember OIDC return URL and drop unreachable AdminPanel render on main - #551
fix(frontend): remember OIDC return URL and drop unreachable AdminPanel render on main#551seonghobae wants to merge 1 commit into
Conversation
…el render main's login screen builds returnUrl via raw string concatenation instead of returnUrlFromLocation()/rememberOidcReturnUrl(), leaving both imports unused (TS6192) and rendering an AdminPanel with accessToken: string | undefined on the unauthenticated branch (TS2322) -- pnpm run build fails on main's current tip. This is the same bug pattern fixed independently across several feature branches this session; landing it on main directly stops every branch built from main's tip from inheriting the broken build.
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Superseded — main's tip (78a65f9, merged via #426) already carries an equivalent fix for this exact bug (commit 11a60b3, "fix(frontend): repair the inherited login/admin-panel build break"). Verified |
1 participant
Summary
main's current tip (ef6f5a5f) failspnpm run build: the unauthenticated login screen buildsreturnUrlvia raw string concatenation instead ofreturnUrlFromLocation()/rememberOidcReturnUrl(), leaving both imports unused (TS6192), and renders an<AdminPanel accessToken={accessToken} />on that same branch whereaccessToken: string | undefined(TS2322).origin/mainvia a worktree build before touching anything:pnpm run buildreproduces both errors on the unmodified tip.AdminPanelrender (the authenticated branch's occurrence is already guarded by the earlierif (!accessToken) return).sessionStorageassertion toApp.test.tsx.This same bug pattern has been showing up independently across many feature branches all session (each presumably rebased from/merged through this same broken tip). Landing the fix on
maindirectly should stop new branches from inheriting it.Test plan
pnpm run lint— cleanpnpm run build— clean (previously failed with TS6192 + TS2322)pnpm exec vitest run --testTimeout 20000— 140/140 passeduv run pytest -q— 656 passed, 114 skippedhttps://claude.ai/code/session_01B5M79L945DMyMs3sg5yJ14