docs: refresh live product and technical gap baseline - #600
Conversation
|
Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough기술 격차 기준선 문서가 2026-08-25 스냅샷을 반영하도록 갱신되었습니다. 최신 PR·이슈 큐, Strix 시스템 게이트, 전달된 PR, 접근성 격차, 수용 절차가 업데이트되었습니다. Changes기술 격차 기준선 문서
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to The baseline refresh still contains conflicting exact-head evidence and an incorrect protected-release PR count, which could mislead future tracking and gap assessment. The PR is otherwise mergeable with owner follow-up on these bounded documentation-correctness issues. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
23d3552 to
fb825b9
Compare
8e4570c to
f60cff0
Compare
# Conflicts: # docs/product-technical-gap-baseline.md
The login button computed returnUrl manually (window.location.pathname + window.location.search), which drops the URL hash fragment and never calls rememberOidcReturnUrl. Two defects followed: tsc -b fails on the now-unused returnUrlFromLocation / rememberOidcReturnUrl imports (build-breaking), and the sessionStorage/ localStorage fallback that restoreOidcReturnUrl (main.tsx) depends on when the OIDC state round-trip is dropped was never populated. Both are exercised by the existing App.test.tsx assertion and were already failing before this change. Call returnUrlFromLocation() (includes the hash, strips callback params) and rememberOidcReturnUrl() before signinRedirect, restoring the ADR 0109 pattern this repository's own docs already describe as present. Pre-existing on protected main, independent of this PR's own changes; found while verifying this merge and confirmed by a clean build of origin/main alone. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…/ContextualWisdomLab/LineageWeave into HEAD # Conflicts: # docs/product-technical-gap-baseline.md
…/ContextualWisdomLab/LineageWeave into HEAD # Conflicts: # docs/product-technical-gap-baseline.md
| const returnUrl = returnUrlFromLocation(); | ||
| rememberOidcReturnUrl(returnUrl); |
There was a problem hiding this comment.
📝 Info: Login return URL now includes hash, strips callback params, and is persisted
The login handler no longer builds the return URL as pathname + search. returnUrlFromLocation() (oidcReturnUrl.ts:26) also appends location.hash, strips OIDC callback params, and falls back to / for unsafe values, and rememberOidcReturnUrl() now persists it to session/local storage. Helpers are imported at App.tsx:102; behavior matches the ADR 0109 pattern.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Validation
uv run pytest -q tests/test_documentation_hygiene.py(5 passed)git diff --checkSummary by CodeRabbit