Skip to content

docs: fix temporal topic and mathematical compute contracts - #617

Merged
seonghobae merged 1 commit into
feat/dashboard-live-evidencefrom
feat/temporal-topic-influence-contracts
Aug 25, 2026
Merged

docs: fix temporal topic and mathematical compute contracts#617
seonghobae merged 1 commit into
feat/dashboard-live-evidencefrom
feat/temporal-topic-influence-contracts

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • fixes the TEPP temporal/Event-Lineage topic producer boundary
  • fixes the fast-mlsirm multiple-membership multilevel case-deletion influence estimand
  • inventories every local Python mathematical path and assigns its Rust CPU/GPU owner
  • adds an AST guard against new local numerical implementations

Evidence

  • Local Zotero Connector received eight primary-source records with original-source URLs
  • uv run --extra dev pytest -q tests/test_math_boundary_inventory.py tests/test_documentation_hygiene.py tests/test_public_docstrings.py (8 passed)

Stack

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a0060970-5c67-4d8a-8bdb-a29eb1653f66

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit 3e3b3ee into feat/dashboard-live-evidence Aug 25, 2026
2 of 4 checks passed
seonghobae added a commit that referenced this pull request Aug 25, 2026
* feat(lineage): require TEPP criterion anchor for weights

* fix(tepp): preserve exact cutoff precision

* feat(dashboard): add evidence operations workspace

* fix(tepp): enforce canonical anchor UUID

* fix(frontend): keep merged OIDC imports minimal

* feat: complete semantic dashboard evidence paths

* fix(tepp): promote only exact accepted lineage vectors

* Revert "fix(tepp): promote only exact accepted lineage vectors"

This reverts commit bc182f1.

* fix(tepp): promote exact accepted lineage vectors

* fix: bind semantic retrieval to resolved model

* fix: bind semantic retrieval to resolved model and page VOC

* fix(ui): preserve settled calendar status semantics

* fix(lineage): preserve focused isolation reason

* fix: close semantic evidence review gaps

* docs: refresh exact-head product gap baseline

* fix(ui): preserve dashboard controls during reload

* feat(dashboard): distinguish retryable analysis failures

* fix(ui): isolate similar VOC pagination by post

* docs: record exact-head dashboard acceptance evidence

* fix(ui): keep failed-analysis guidance coherent

* fix(ui): drop stale similar VOC pages after navigation

* test: type similar VOC fetch fallback

* feat(dashboard): cite linked evidence posts

* fix(api): keep similar VOC query in one audited template

* fix(ask): restrict evidence to semantic candidates

* fix(api): bound similar VOC adjudication

* docs: fix temporal topic compute contracts (#617)

Co-authored-by: seonghobae <seonghobae@users.noreply.github.com>

---------

Co-authored-by: seonghobae <seonghobae@users.noreply.github.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment on lines +21 to +41
def _numerical_import_files() -> set[str]:
"""Return production Python files importing a numerical owner package."""

found: set[str] = set()
for base in (ROOT / "lineageweave", ROOT / "backend" / "app"):
for path in base.rglob("*.py"):
tree = ast.parse(path.read_text(encoding="utf-8"), filename=str(path))
imports = {
alias.name.split(".", 1)[0]
for node in ast.walk(tree)
if isinstance(node, ast.Import)
for alias in node.names
}
imports.update(
node.module.split(".", 1)[0]
for node in ast.walk(tree)
if isinstance(node, ast.ImportFrom) and node.module
)
if imports & NUMERICAL_OWNER_MODULES:
found.add(path.relative_to(ROOT).as_posix())
return found

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Guard freezes import surface, not local math

The guard in test_math_boundary_inventory.py flags only files importing {fast_mlsirm, numpy, rankweave, scipy, sklearn}. Local numerical code using stdlib math or hand-rolled arithmetic (e.g. embedding_client.py cosine, knowledge_graph.py RWR, backend/app/post_chat_ingestion.py, all named in the audit doc) passes undetected. The expected set matches today, so the test is green, but it does not prevent new pure-Python numerical implementations.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant