feat(ui): share one token-backed status notice - #643
Conversation
Calendar's missing Naruon projection uses StatusNotice (ADR 0214 / #611). Success and unavailable are a named region so App live-region uniqueness holds; retry stays role=alert. Synthetic fixtures only.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact-head UI audit: |
|
Verified current head 041ec13 against ADR 0203: the unavailable branch intentionally renders the fail-closed notice before any event list, and the API contract returns events=[] when naruon_available=false. No actionable defect found in Devin note. Local Vitest: 9 targeted tests passed (StatusNotice, WorkspaceCalendar, Calendar App paths). Protected approval and hosted gates remain required. |
|
Merged current protected-main base and retained both the StatusNotice and semantic-unit changelog entries. New exact head: |
Outcome
StatusNotice(success / unavailable / retry) as current-main ADR 0214, superseding closed-branch ADR 0134 for protectedmainonlyrole="alert"with Retry; success and unavailable stay a named region so App live-region uniqueness (getByRole("status")) holdsIndependent of open stacks #579, #629, #631, #632, #636, #639, #640. Tracks #611; the issue stays open until remaining 0133/0135/0136/0137 slices ship on current main.
Verification
corepack pnpm lint(0 warnings, 0 errors)corepack pnpm test(388 passed)corepack pnpm exec vitest run src/App.test.tsx -t "fails closed on the calendar"(passed)corepack pnpm builduv run --extra dev pytest -q tests/test_documentation_hygiene.py(5 passed)Synthetic fixtures only. No keyword, heuristic, arbitrary threshold, or local measurement weight is introduced.