Skip to content

feat(ui): share one token-backed status notice - #643

Open
seonghobae wants to merge 5 commits into
mainfrom
feat/status-notice-shared-alert-v219
Open

feat(ui): share one token-backed status notice#643
seonghobae wants to merge 5 commits into
mainfrom
feat/status-notice-shared-alert-v219

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Outcome

  • adds shared StatusNotice (success / unavailable / retry) as current-main ADR 0214, superseding closed-branch ADR 0134 for protected main only
  • migrates Calendar's Naruon fail-closed path so missing projection copy and the next action sit in one named region
  • keeps retry on role="alert" with Retry; success and unavailable stay a named region so App live-region uniqueness (getByRole("status")) holds
  • distinguishes kinds by label and glyph, not color alone (ADR 0099 tokens); never interpolates provider payloads (ADR 0123)

Independent of open stacks #579, #629, #631, #632, #636, #639, #640. Tracks #611; the issue stays open until remaining 0133/0135/0136/0137 slices ship on current main.

Verification

  • corepack pnpm lint (0 warnings, 0 errors)
  • corepack pnpm test (388 passed)
  • corepack pnpm exec vitest run src/App.test.tsx -t "fails closed on the calendar" (passed)
  • corepack pnpm build
  • uv run --extra dev pytest -q tests/test_documentation_hygiene.py (5 passed)

Synthetic fixtures only. No keyword, heuristic, arbitrary threshold, or local measurement weight is introduced.


Open in Devin Review

Calendar's missing Naruon projection uses StatusNotice (ADR 0214 / #611).
Success and unavailable are a named region so App live-region uniqueness
holds; retry stays role=alert. Synthetic fixtures only.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 38595f0d-c592-489c-9280-db36e8beb5e1


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head UI audit: 041ec13b passed StatusNotice and WorkspaceCalendar component tests (8), lint, and Storybook build. The Unavailable scene was rendered and visually inspected at 1200×600 and 390×600: named state, message, and next action remain readable without horizontal overflow; the glyph plus visible label keeps state distinguishable without color alone. Screenshots used synthetic content and remain local, not committed.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Verified current head 041ec13 against ADR 0203: the unavailable branch intentionally renders the fail-closed notice before any event list, and the API contract returns events=[] when naruon_available=false. No actionable defect found in Devin note. Local Vitest: 9 targeted tests passed (StatusNotice, WorkspaceCalendar, Calendar App paths). Protected approval and hosted gates remain required.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Merged current protected-main base and retained both the StatusNotice and semantic-unit changelog entries. New exact head: 7fb4d18c69e18700229dbacb0690a891fb7b41ea. Hosted checks and independent review remain required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant