feat(tepp): add terminal status read boundary - #662
Conversation
📝 WalkthroughWalkthroughTEPP 제출과 상태 조회 transport를 분리했습니다. 실행 ID를 검증하고 URL 경로로 인코딩합니다. 공통 계약 헤더와 인증 헤더를 전송합니다. 상태 조회 오류는 ChangesTEPP 상태 조회
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🔵 Low · up to The change adds terminal-status reads, but trimming opaque run identifiers can make some valid status lookups fail, and the ADR records a future date. These are localized issues requiring owner awareness or follow-up; no broader merge-blocking risk is indicated. Sequence Diagram(s)sequenceDiagram
participant Caller
participant TeppClient
participant configured_tepp_client
participant TEPPEndpoint
Caller->>TeppClient: get_analysis_run_status(run_id)
TeppClient->>TeppClient: run_id 검증 및 trim
TeppClient->>configured_tepp_client: 상태 조회 요청
configured_tepp_client->>TEPPEndpoint: 인코딩된 run_id로 GET 요청
TEPPEndpoint-->>configured_tepp_client: 상태 JSON envelope
configured_tepp_client-->>TeppClient: 상태 envelope 또는 TeppNotAvailable
TeppClient-->>Caller: 상태 조회 결과
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 16 functions across 3 files. (3 skipped: 3 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed exact head |
|
Rechecked current exact head |
|
Rechecked exact head |
|
PR #657이 동일한 TEPP 상태 조회 책임을 더 강한 request/snapshot/cutoff/output 결합 검증과 함께 소유합니다. 이 PR의 검증 없는 별도 get_analysis_run_status 경계는 그 계약을 우회할 수 있어 중복 구현을 병합하지 않습니다. #657로 대체 종료합니다. |
Pull request was closed
Summary
Evidence
Boundary
TEPP PR #157 publishes Rust wire types but no executable HTTP status route. This PR therefore does not derive a URL, attach credentials, poll, persist a terminal result, or treat accepted/running as measurement.
Refs #277