Skip to content

fix(ui): guide cancelled analysis runs - #669

Merged
seonghobae merged 7 commits into
chore/refresh-gap-baseline-20260826from
feat/cancelled-analysis-next-actions
Aug 25, 2026
Merged

fix(ui): guide cancelled analysis runs#669
seonghobae merged 7 commits into
chore/refresh-gap-baseline-20260826from
feat/cancelled-analysis-next-actions

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • give every terminal Cancelled analysis kind an evidence-safe next action
  • keep TEPP and topic-lineage guidance at the owning service boundary
  • make analysis-run cards readable at desktop and phone widths
  • retain authenticated synthetic-runtime screenshots and Gap baseline evidence

Verification

  • corepack pnpm run lint
  • corepack pnpm exec vitest run src/App.test.tsx -t 'gives a cancelled' (4 passed)
  • corepack pnpm run build
  • authenticated Compose audit at 1440×1000 and 390×844 with four synthetic Cancelled kinds

Stack

Base: #667 (chore/refresh-gap-baseline-20260826). Merge this PR into that branch first; protected-main delivery remains contingent on #667's exact-head gates.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: de2bf4be-81f2-4b2d-b934-855574364fb5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Validated current exact head f78b69c (the branch advanced to 1b5bea3 during the local run; re-fetch required before lifecycle action). Clean frontend worktree App tests passed: 99 passed. No unresolved review threads or current failed Checks; hosted Tests remain queued.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Correction: exact current head is 1b5bea33 (remote advanced during validation); the 99-pass App test run was against that current branch head. Re-fetch this SHA again immediately before lifecycle action.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Fixed the buyer-visible layout note at exact head a1597b6: succeeded/non-actionable analysis runs now use a two-column grid and no longer reserve an empty next-action column. App tests pass 99/99 in a clean frontend worktree.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Corrected the grid contract at exact head 2617520: classes now distinguish document-count and next-action presence, so cancelled/pending runs place the action in the wide second column while succeeded runs use a compact layout. Clean App test run: 99 passed.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae
seonghobae merged commit b0c3dc2 into chore/refresh-gap-baseline-20260826 Aug 25, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant