feat(separation): add authoritative human approval boundary - #129
Draft
seonghobae wants to merge 16 commits into
Draft
feat(separation): add authoritative human approval boundary#129seonghobae wants to merge 16 commits into
seonghobae wants to merge 16 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible gap
Parent PR #46 creates value-minimized, human-review-required Employment separation evidence but deliberately cannot authorize mutation or downstream execution. This dependency-first Orgmetra-only lane adds the missing accountable human-approval boundary before any later authoritative Employment/Assignment mutation or foreign-owner handoff.
Implemented approval boundary
approve_employment_separation(...)accepts only the exact governed parent packet runtime type, freezes the approval instant to built-in UTC evidence, requires the accountable reviewer as approving actor, snapshots the exact parent canonical bytes/SHA-256 around authority work, validates exact tenant/review/Person/Employment/reviewer/approval-instant authority evidence, and issues only a value-minimized receipt fixed tohuman_approved_for_authoritative_resolution,not_authorized_to_apply, andnot_authorized_to_execute.The receipt uses process-local HMAC-backed issuance evidence outside receipt-writable slots and is defense-in-depth only. Durable systems must persist already-issued canonical evidence through immutable audit/outbox and freshly authorize consequential mutation/external action.
Current exact stack state
4c377a35055e126a5e2435ec36bd9ac1e593456efeat/governed-employment-separation-review96fe0b69e8e1bc3caa0fa206146a87c6e502774615d534fc8e36d3455523cf5d8e22e77010fc9d4bdevelop@9e3e4847510e1e612b48474ba42b177b8ed824dfThe child is therefore currently based on a predecessor snapshot of parent #46 and is stale relative to the parent's live head. The earlier PR prose claiming this child had already been adapted to the current parent was incorrect. Do not restack or churn this Draft child merely to manufacture descendant evidence while #46 remains unintegrated; process the parent dependency-first. After #46 actually integrates, retarget/rebase this existing child branch onto the then-current protected
developand revalidate the resulting exact child head from scratch. Predecessor parent/child checks and reviews remain non-transferable.Exact-current-child evidence
A fresh exact-head check inventory contains exactly one check run on
4c377a35055e126a5e2435ec36bd9ac1e593456e: Employment Separation Review Quality run33166590078, job/check98833356045, terminal SUCCESS. Its fresh job log proves exact checkout of this child head, compile success, 137 tests passed, owned production 388/388 statements and 86/86 branches (100.00%), and a clean-checkout gate.That one stack-local focused workflow is the entire exact-child-head check inventory. Required OpenCode/Noema/Strix/SAST/Security/central coverage evidence is absent on this exact child head and therefore non-passing. There are no qualifying independent current-head non-author approvals; predecessor or parent evidence may not be transferred.
Parent dependency remains blocking
Parent #46 is still open · Draft · mergeable at exact head
15d534fc8e36d3455523cf5d8e22e77010fc9d4bagainstdevelop@9e3e4847510e1e612b48474ba42b177b8ed824df.Its current exact-head Orgmetra-owned evidence is substantially healthier than the predecessor snapshot previously recorded here: Employment Separation Review Quality is terminal GREEN with 110 tests passed and 207/207 statements plus 54/54 branches (100.00%); Foundation, Recovery, and SAST are also GREEN. The remaining current blockers are central/independent-evidence boundaries rather than missing local package proof:
ContextualWisdomLab/.github#810.APPROVEDorCHANGES_REQUESTEDverdict; existing owner handoff:ContextualWisdomLab/.github#624./healthz; existing owner handoff:ContextualWisdomLab/.github#1399.33278974477is terminal CANCELLED with 0 materialized jobs; a supported unchanged-headrerun-failed-jobsattempt returns HTTP 403This workflow run cannot be retried, so no authoritative scanner verdict exists; existing owner handoff:ContextualWisdomLab/.github#1327.Consequently the child's focused GREEN result does not cure or replace the parent evidence gap, and parent checks/reviews may not be transferred to this child.
Stack governance
Keep this child Draft while #46 is unmerged. Process #46 dependency-first. Only after #46 actually integrates may this child be retargeted/revalidated against the then-current protected
develop; every applicable local and central gate must then be rerun on that resulting exact child head.Do not self-approve, use routine administrator bypass, weaken a gate, create no-op evidence churn, race another lifecycle writer, or treat queued/cancelled/absent/predecessor/status-only/model-only evidence as passing.
Scope / non-claims
This slice establishes a governed human-approval receipt only. It does not itself mutate Employment/Assignment state, execute separation, persist foreign-owner payloads, bypass authoritative tenant/identity resolution, or claim deployed production integration, certification, legal-compliance determination, or commercial release.