fix(core): harden bitemporal interval runtime integrity - #69
Conversation
|
Warning Review limit reached
Next review available in: 52 seconds Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@opencode-agent Please review the current unchanged head against protected |
Verified protected-main defect
Protected
develop@9e3e4847510e1e612b48474ba42b177b8ed824dfaccepts caller-controlled subclasses at the shared HRIS bitemporal interval boundary. Pythondate/datetimesubclasses can participate in effective-time and recorded-time visibility decisions, andRecordedIntervalpreviously treated non-nulltzinfoas sufficient even when no usable UTC offset existed. A custom timezone implementation could also regain control during later comparisons after an initial validation call.RED → root-cause repair
f425c3878b923e6e626d79617d82377ebf77d235requires exact built-in temporal primitives for stored bounds and query coordinates.2b37ad4e8ac2cb6337d8e2e69f9ca39175d0d207proves a non-nulltzinfowhoseutcoffset()isNoneis still invalid system-time evidence.827342a9a1ff102942584a574c81ca4b61bb0c31introduces exact primitive validation and usable-offset validation at the shared interval boundary.e0e4e677dffd4285dea39bdd51509d599085d100proves hostile timezone exceptions normalize to stableIntervalErrorrather than leaking arbitrary provider behavior.99095287bfa7ebf421f776d6f823a6b2dc448525proves interval subclasses themselves and a one-shot custom timezone can regain control after validation unless the boundary detaches executable timezone behavior.ee0f5410c19468e71291f77053da1017704ed438makesDateInterval/RecordedIntervalnon-subclassable, requires exact interval operands for overlap, and copies validated recorded timestamps onto fixed built-in timezone objects before storing/comparing them.7a4fd263546a5c1790a046fbb9b6ff60ba160960exercises non-interval overlap operands plus non-zero fixed-offset canonicalization for the repository's exact statement/branch coverage contract.docs/doctoring/bitemporal-interval-runtime-references.mdanddocs/traceability/bitemporal-interval-runtime-integrity.mdwithout changing canonical documents owned by PR docs: reconcile canonical protected product truth #51.The accepted model remains unchanged: business/effective time and system-recorded time are separate, intervals are half-open, and retroactive corrections remain correction-not-rewrite.
Exact-current-head evidence
Current exact head:
7a4fd263546a5c1790a046fbb9b6ff60ba160960.Fresh live protected base:
develop@9e3e4847510e1e612b48474ba42b177b8ed824df.GitHub reports the PR open, ready-for-review, and mergeable.
Fresh exact-head hosted workflows are terminal GREEN on this unchanged head:
32512260373— success32512260506— success32512260433— success32512260486— success32512260761— success32512260652— success32512260470— successFresh review verification finds no submitted reviews and no review threads. No qualifying formal independent non-author APPROVE is present.
Scope
Orgmetra-only HRIS-kernel repair. No dedicated-writer dependency repository, source, ref, workflow, PR state, credential or application table is modified.
Merge discipline
The unchanged exact head has terminal applicable GREEN hosted evidence, mergeability is freshly resolved, and no valid unresolved review finding exists, so this lane is ready for qualifying independent review. Ready-for-review is not approval and does not authorize merge. Immediately before merge refetch exact head/base/reviews/threads/rules/checks and use expected-head protection. Do not self-approve, weaken a gate, or reuse predecessor evidence.