Skip to content

feat(core): serialize bounded WebDriver BiDi locateNodes commands - #181

Merged
seonghobae merged 15 commits into
cursor/bc-76ee265e-c335-4e79-9ce1-985ad0d8ea71-aa6bfrom
feat/webdriver-bidi-locate-nodes-command
Aug 26, 2026
Merged

feat(core): serialize bounded WebDriver BiDi locateNodes commands#181
seonghobae merged 15 commits into
cursor/bc-76ee265e-c335-4e79-9ce1-985ad0d8ea71-aa6bfrom
feat/webdriver-bidi-locate-nodes-command

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Stacked on exact PR #174 head ec6293eb86666a5de335d0a71674215a8953db33.

Buyer gap

#174 closes protocol-proof and node-admission confusion, but its current truth boundary explicitly stops before serializing or transmitting a WebDriver BiDi command. This child owns the next bounded boundary: deterministic, fail-closed serialization of the reviewed browsingContext.locateNodes accessibility query into an exact WebDriver BiDi command envelope. It performs no transport I/O and grants no browser, policy, destination, or typed-input authority.

Implemented contract

Current exact head d28836ae8c0f2096f214d681f001d60e9fcb780b:

  • accepts only WebDriver BiDi js-uint command IDs, including 0 and 9007199254740991, and rejects larger u64 values;
  • validates the browsing-context identifier against the existing external browser identifier budget and protocol-text injection policy;
  • JSON-escapes reviewed string values while preserving ordinary Unicode text;
  • serializes the exact accessibility locator, finite maxNodeCount, and fixed minimal serialization options already carried by WebDriverBiDiAccessibilityQuery;
  • exposes source-free typed validation errors;
  • records the implemented boundary in CHANGELOG.md; and
  • grounds the command envelope and locateNodes parameter shape in the W3C WebDriver BiDi Editor’s Draft dated 20 July 2026 in docs/doctoring/browser-agent-protocols.md.

This remains an inert transport value: it does not authenticate a browser or adapter, perform transport I/O, bind the command to current OriginWeave session/context/origin authority, correlate a response, admit returned nodes, or authorize policy/typed input.

Exact-head evidence

For unchanged exact head d28836ae8c0f2096f214d681f001d60e9fcb780b:

  • repository CI run 32058217738: success;
  • Manifest V3 Compatibility run 32058217732: success;
  • no formal review or unresolved review thread is currently present.

These checks are head-specific; no predecessor evidence is transferred.

Stack discipline

Keep Draft while #174 and its prerequisites remain active. PR #182 owns the next response-correlation slice and is stacked on this head. No predecessor check/review/coverage evidence transfers. This scheduled actor does not merge, self-approve, alter workflows, add secrets, weaken checks, tag, or publish.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ada33fd5-ee25-42cb-baf6-11488bb1a6a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 26, 2026 20:57
devin-ai-integration[bot]

This comment was marked as resolved.

…locate-nodes-response-correlation

feat(core): correlate WebDriver BiDi locateNodes responses
@seonghobae
seonghobae merged commit 05a5234 into cursor/bc-76ee265e-c335-4e79-9ce1-985ad0d8ea71-aa6b Aug 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant