Skip to content

feat(network): promote bounded WebDriver BiDi transport stack - #198

Merged
seonghobae merged 206 commits into
feat/webdriver-bidi-websocket-opening-writefrom
feat/webdriver-bidi-websocket-handshake-response
Aug 26, 2026
Merged

feat(network): promote bounded WebDriver BiDi transport stack#198
seonghobae merged 206 commits into
feat/webdriver-bidi-websocket-opening-writefrom
feat/webdriver-bidi-websocket-handshake-response

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Promotes the reviewed WebDriver BiDi transport stack into the opening-write branch:

  • RFC 6455 opening-response validation and client nonce redaction
  • bounded masked WebSocket frame transport
  • bounded locateNodes exchange with correlation, fragmentation/control-frame budgets, fresh client masking keys, and one end-to-end deadline

Exact lineage

Every source slice passed Rust contracts and exact owned-production function, line, region, and branch coverage. No predecessor review or check is treated as transferable: this promotion requires its own exact-head CI and terminal review.

Safety boundary

This stack authenticates and bounds the loopback WebDriver BiDi transport and locateNodes exchange. It does not grant browser, page, policy, extension, or Agent authority; reconnect; inherit proxies; expose unrestricted JavaScript; or claim a release.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e640bff7-2fb5-4c24-94e6-d2728b1f02e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…websocket-frame-transport

feat(network): add bounded WebSocket frame transport
…websocket-locate-nodes-exchange

feat(network): exchange bounded BiDi locateNodes over WebSocket
…websocket-frame-transport

feat(network): promote bounded BiDi locateNodes exchange
@seonghobae seonghobae changed the title feat(network): validate WebSocket opening response feat(network): promote bounded WebDriver BiDi transport stack Aug 26, 2026
@seonghobae
seonghobae marked this pull request as ready for review August 26, 2026 19:16

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@seonghobae
seonghobae merged commit f6b0c7f into feat/webdriver-bidi-websocket-opening-write Aug 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant