feat(workspace): consolidate first-range rehearsal navigation - #1143
feat(workspace): consolidate first-range rehearsal navigation#1143seonghobae wants to merge 30 commits into
Conversation
The ready map already names the first playable span. Players still had
to hunt the structure timeline for when that section happens. Offer
Find {section} at {clock} on the timeline, fail closed on duplicate
labels or unusable clocks, and highlight the matching cell.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (9)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough첫 연주 가능 범위를 고유 식별자로 검증하고, 타임라인과 로드맵에서 해당 섹션 또는 역할을 찾는 버튼을 추가했습니다. 포커스 요청은 반복 실행, 곡과 프로젝트 변경, 잘못된 시간 및 중복 식별자를 처리합니다. Changes첫 연주 가능 범위 탐색
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to The navigation controls validate targets, clear stale focus across song and project changes, and honor reduced-motion behavior without an identified current-head regression. Sequence Diagram(s)sequenceDiagram
participant Player
participant Workspace
participant firstRangeRoadmap
participant SectionRoadmap
Player->>Workspace: 로드맵 찾기 버튼 클릭
Workspace->>firstRangeRoadmap: 섹션 및 역할 확인
firstRangeRoadmap-->>Workspace: 검증된 sectionId와 roleId 반환
Workspace->>SectionRoadmap: 포커스 요청 전달
SectionRoadmap->>SectionRoadmap: 대상 역할 카드를 scrollIntoView
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 72.41% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 29 functions across 9 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
seonghobae
added
enhancement
ChatGPT Codex Connector
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
seonghobae
changed the title
|
Canonical single-writer repair for the overlapping first-range UI boundary. Fresh semantic comparison on the current protected base ( Treat this PR as the consolidation owner. Do not merge it until those unique #1142/#1147 behaviors, tests, locale contracts, and still-valid documentation evidence are reconstructed here (or a verified successor) and fresh exact-head checks/reviews pass. The sibling PRs remain preservation children until complete semantic succession; no predecessor approval/check evidence transfers. Direct base retargeting currently exposes real overlapping-file conflicts, so conflict resolution must preserve both behaviors rather than dropping a side. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
🔍 Focused tests need external confirmation
The workspace suites could not start without installed dependencies; Vite failed to resolve its React plugin. CI must provide the missing execution evidence.
Was this helpful? React with 👍 or 👎 to provide feedback.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
1 participant
Product outcome
BandScope’s first playable-range cue links a buyer-visible rehearsal decision back to two existing surfaces without starting playback: the structure timeline answers when the range occurs and Section Roadmap identifies the exact part. #961 remains the Active Player owner.
Exact current identity
develop@314ddeae7b775a4957594b599358c8255617eb2efeat/workspace-find-first-range-sectiondec3d69a4d5e4c92fc57c4e508ee87771e9a2725ahead_by=30,behind_by=0; merge base is the protected head itselfThe former head
d657b8d17222e23e7acf95c43766016bb3f013fahad diverged from protecteddevelopwith merge base749511c3ad4000090048718f685c6bee6b3d2c25and was two protected commits behind. It was repaired by an ordinary two-parent descendant commit, not force-push or destructive rebase. The restack preserves every one of this PR’s 16 semantic files while explicitly reconciling the two overlapping documents:CHANGELOG.mdkeeps the #1165 security-backstop consolidation truth and this PR’s expanded first-range navigation note;docs/architecture/overview.mdkeeps the protected CI/control-plane description and this PR’s mounted timeline/roadmap behavior.This PR remains the canonical consolidation owner for the first-range Workspace navigation fan-out. #1147 was previously closed only after its valid roadmap-navigation delta was preserved here. No predecessor check/review/approval evidence transfers to the new head.
Current behavior
firstRangeSqueezeowns playable-range presentation truth only: it preserves a complete ordered scientific-pitch span, role/section copy, overlap warning, and the source record’s exact string IDs even when those IDs are unsafe for DOM navigation.firstRangeTimelineadmits navigation only when the exact source section ID is canonical and unique and start/end clocks are finite, non-negative, and strictly increasing.firstRangeRoadmapadmits navigation only when the exact section ID is unique across the map and the exact role ID is unique within that section.prefers-reduced-motion: reduce, and roadmap Find scrolls the exact requested role card.Verification boundary
The prior exact-head checks belong to
d657b8d…and are stale after the restack.dec3d69…must reacquire all applicable repository/organization checks, review findings and independent approval on the unchanged head. Draft status is intentional until that evidence is terminal-success.UI Delivery Gate remains FAIL until current-head CI/coverage/security/review evidence is green and the applicable pointer, keyboard, focus, reduced-motion, responsive, persistence/reload and accessibility paths are current-head verified. This navigation slice does not claim playback, MIR, filesystem, network, credential or release authority.
Do not self-approve. Merge only on the unchanged exact head after every applicable required check is terminal-success, all valid review findings are resolved, and a qualifying independent non-author approval applies to the last push.
Summary by CodeRabbit
새로운 기능
버그 수정