feat: bind evidence and make assessment retries idempotent - #12
feat: bind evidence and make assessment retries idempotent#12seonghobae wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head review request for a1035e2: evidence is registration-bound and assessment imports are idempotent for identical retries, while mismatched source or registration reuse conflicts. Local Rust checks, schema/actionlint validation, and real PostgreSQL 18.4 evidence passed. Please independently review this exact head and rerun required checks; no approval or protected merge bypass is requested.
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review request for 2ed7330. Re-verify the exact-head diff, required Checks, tenant/security boundaries, and any valid review findings after the shared Rust component-install fix. COMMENT only; no approval or protected-merge bypass is requested.
Summary
Buyer-visible outcome
A provider can safely retry an assessment-result import without duplicating evidence, while a result cannot be reused across registrations or silently attached to a different external result. Completion decisions now query evidence only from the requested registration.
Evidence
cargo fmt --all -- --checkcargo test --workspace --all-targets --locked(6 passed)cargo clippy --workspace --all-targets --locked -- -D warningsRUSTDOCFLAGS=-Dwarnings cargo doc --workspace --no-deps --lockedcargo build --bin lms_api --lockedactionlintand JSON schema sanity check409; evidence rows were registration-bound; completion and credential revocation succeededScope boundary
This remains a CWL-owned reference projection. A released Psychometrics Commons client/provider contract test, QTI conformance, assessment execution/scoring, audit/outbox, browser E2E, and production coverage/load evidence remain open.
Merge gate
This PR is stacked on PR #11. Review the exact current head and rerun required checks. No self-approval or protected-branch bypass is requested.