Skip to content

feat: add cursor pagination to audit export - #19

Open
seonghobae wants to merge 1 commit into
feat/postgresql-recovery-evidencefrom
feat/audit-export-cursor
Open

feat: add cursor pagination to audit export#19
seonghobae wants to merge 1 commit into
feat/postgresql-recovery-evidencefrom
feat/audit-export-cursor

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add paired after_occurred_at and after_audit_event_record_id keyset pagination to tenant audit export
  • reject partial cursors with HTTP 400 while preserving the existing array response and bounded limit
  • add ADR-0004, PRD/TRD/architecture/runbook traceability, and exact-head PostgreSQL/API smoke coverage

Real PostgreSQL/API evidence

  • PostgreSQL 18.4 disposable database and running Rust API
  • first page returned 2 events; cursor page returned the remaining 3 in stable order
  • partial cursor returned HTTP 400
  • second tenant returned an empty array
  • source payloads remained excluded

Verification

  • cargo +1.97.1 fmt --all -- --check
  • cargo +1.97.1 test --workspace --all-targets --locked
  • cargo +1.97.1 clippy --workspace --all-targets --locked -- -D warnings
  • RUSTDOCFLAGS="-D warnings" cargo +1.97.1 doc --workspace --no-deps --locked
  • actionlint, docs contract, and git diff --check

Gate

This PR is stacked on PR #18 exact head f0a5e55. It remains subject to independent current-head review, required Checks, and protected merge rules. No self-approval, merge, or protection bypass is requested.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 52b6ceef-9be0-462f-b37c-6a0eb33e0efb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@opencode-agent Review only the exact current head a718bfe against base f0a5e55 for PR #19. Do not update branches, approve, merge, or bypass protection. Check keyset cursor semantics, tenant/RLS isolation, SQL parameter ordering, URL/query validation, backward compatibility, and the real PostgreSQL/API smoke contract.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant