feat: add effective learner affiliations - #6
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Please perform an independent review of the exact current head |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review request for c0aa670. Re-verify the exact-head diff, required Checks, tenant/security boundaries, and any valid review findings after the shared Rust component-install fix. COMMENT only; no approval or protected-merge bypass is requested.
# Conflicts: # CHANGELOG.md # README.md # docs/ARCHITECTURE.md # docs/product-technical-gap-baseline.md
|
@OpenCode review only the exact current head 4cfb77f against base b92fc86. Re-check effective-dated affiliation validity, same-kind overlap conflict handling, parallel affiliation semantics, tenant isolation, and the reconciled parent workflow. Leave an independent review or approval for this exact head only. Do not update code, merge, self-approve, bypass protections, or treat queued Checks as proof. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| --header 'content-type: application/json' --data "$payload" \ | ||
| "http://127.0.0.1:8080/v1/tenants/$tenant_id/learners")" = '409' | ||
| learner_id=$(python3 -c 'import json, sys; print(json.load(open(sys.argv[1]))["learner_id"])' "$RUNNER_TEMP/lms_api_response.json") | ||
| affiliation_id=$(curl --fail --silent --show-error --request POST \ |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head4cfb77f5403cba5fd53c37a794da1d2695ecf999. -
Head SHA:
4cfb77f5403cba5fd53c37a794da1d2695ecf999 -
Workflow run: 32701003305
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: quality.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: quality.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (3 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (3 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Docs (2 files)"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs (2 files)"]
R3 --> V3["docs review"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: quality.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: quality.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (3 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (3 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Docs (2 files)"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs (2 files)"]
R3 --> V3["docs review"]
|
2 participants
Summary
Evidence
4cfb77f5403cba5fd53c37a794da1d2695ecf999b92fc86438b881c2d83cb2d98f8d21337811623factionlint .github/workflows/quality.ymlcargo +1.97.1 fmt --all -- --checkcargo +1.97.1 test --workspace --all-targets --lockedcargo +1.97.1 clippy --workspace --all-targets --locked -- -D warningsRUSTDOCFLAGS='-D warnings' cargo +1.97.1 doc --workspace --no-deps --locked201, first partner affiliation201, overlapping partner affiliation409, parallel customer affiliation201, cross-tenant affiliation400git diff --checkScope boundary
This is the effective-dated affiliation slice of issue #3. Sponsor/payer role records, external identity/Orgmetra adapters, progress, assessment, completion execution, credential issuance, browser E2E, and production readiness remain follow-up work.
Review request
Please review the exact current head
4cfb77f5403cba5fd53c37a794da1d2695ecf999againstb92fc86438b881c2d83cb2d98f8d21337811623f. Do not treat local or green CI checks as semantic approval.