feat(desktop): approved folder tools, Chromium-only images, and reliable Quit (S10) - #509
Merged
Merged
Conversation
davidmckayv
requested review from
MikeRyanDev,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 13, 2026 00:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S10 lets a selected Bot use folders approved by the desktop owner. The native broker enforces Bot/actor/session grants; reads are read-only, writes preserve a backup, and writes or isolated offline commands require native approval. Revocation and Stop/Quit cancel access and work. The same signed server tools serve the app and Admin controls.
This also includes Chromium-only browser packaging, native Quit cleanup, and Windows Podman host routing. The Windows fix configures the owned VM before Compose, resolves the host address through its DNS, and reloads Podman's API only when that configuration changes. This follows Podman's documented WSL networking and API service lifecycle.
The review follow-up protects the additional developer credential stores, including both Cargo credential filenames and GitHub CLI’s documented Windows location. Windows system folders come from the process environment instead of a fixed C: drive. Both computer images copy Bun 1.3.14 from the same official multi-platform image pinned by SHA-256, following Docker’s digest-pinning guidance.
Validation of review follow-up
107a0667:107a0667, including native Windows/macOS/Linux builds and regressions, the Windows process-environment path test, and both image build checks with the deployment startup check.Retained native end-to-end validation from
97cc3651:The Windows visual run used the saved Qwen3-VL 2B/Ollama compatible endpoint. Its initial replies omitted tools or used incorrect chart arguments; the accepted run used an explicit line-chart request. Native approval, file effects, revocation and process termination were checked directly as well as through regression tests.
Closes FOR-302.
Merged into main with admin privileges on 2026-09-13 at David’s instruction. Merge commit:
1d4490aa198ce2eacf722b3e475a5a56d9b5f59f.