Refuse a non-string tool name or args on POST /api/agent-tools/call with 400 - #510
Open
Ayush7614 wants to merge 1 commit into
Open
Refuse a non-string tool name or args on POST /api/agent-tools/call with 400#510Ayush7614 wants to merge 1 commit into
Ayush7614 wants to merge 1 commit into
Conversation
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 13, 2026 05:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The route guarded with
if (!body?.name)and then calledbody.name.replace, so a truthy non-string name (123, {}, ["mcp__x"]) passed the guard and threw a TypeError inside the try, answered as a 200 tool refusal with the marker text instead of a 400.argswas never checked and flowed straight into the store.This adds a pure
parseAgentToolCallInputinserver/src/agents/callback-token.ts(besideauthoriseAgentCall): name must be a non-empty string after trim, args absent means {} and otherwise must be a plain object. The route answers 400 before auth output or the store sees the values, and never calls a string method on untrusted input.Tests: new
server/tests/agent-tool-call-input.test.ts(26 cases: non-object bodies, non-string/blank names, non-object args, mcp__ mapping, trim, no-throw). Verified:bun test server/tests/agent-tool-call-input.test.ts server/tests/agent-callback-token.test.ts server/tests/agent-routes.test.ts— 102 pass.