Refuse a malformed limit on GET /api/admin/audit-events with 400 - #512
Open
Ayush7614 wants to merge 1 commit into
Open
Refuse a malformed limit on GET /api/admin/audit-events with 400#512Ayush7614 wants to merge 1 commit into
Ayush7614 wants to merge 1 commit into
Conversation
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 13, 2026 05:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auditQueryFromUrl matched digits but fell back to 50 on anything else, so ?limit=abc, ?limit=12abc, ?limit=3.9 and ?limit=-5 silently returned the default page while ?from=garbage on the same endpoint answered 400. Channels and people already answer 400 through parsePageLimit.
This reuses parsePageLimit(url limit, 100) and throws AuditQueryError on !ok, so the route's existing catch answers 400 naming the parameter. Absent/blank still means the default 50; digits still clamp 1..100. Also refreshes the paging.ts docstring, which described the old audit fallback.
Tests: new server/tests/audit-limit.test.ts (16 cases: defaults, boundaries, clamp, padding, 6 malformed shapes throwing + route 400 without reaching the store, valid limit reaching the store). Verified: audit cursor + limit + audit suite — 27 pass.