Refuse non-string functions on POST /api/components/:name/decision with 400 - #515
Open
Ayush7614 wants to merge 1 commit into
Open
Refuse non-string functions on POST /api/components/:name/decision with 400#515Ayush7614 wants to merge 1 commit into
Ayush7614 wants to merge 1 commit into
Conversation
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 13, 2026 05:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The route filtered non-string functions out, so {functions:[123,null,{}]} became [] and was answered allowed:true — a fail-open verdict on a governance endpoint. Whitespace Bot ids had the same shape problem one line up (404 instead of 400).
Absent still means none; a present list must be all non-blank strings (400 Functions must be a list of function names.), and the Bot id is trimmed before the presence check. Updates the old test that asserted the ignore-behavior to the corrected 400.
Tests: new server/tests/component-decision-functions.test.ts (18 cases) + updated decision test — 23 pass.