[core] Fix long report/funnel names overlapping header action buttons - #7929
Closed
mrmeghana wants to merge 2 commits into
Closed
[core] Fix long report/funnel names overlapping header action buttons#7929mrmeghana wants to merge 2 commits into
mrmeghana wants to merge 2 commits into
Conversation
The shared cly-header mid-level row placed a shrinkable left slot next to the right-side action buttons, but the left slot had no overflow handling, so long content (e.g. a long funnel name) bled over the buttons on the right. Clip the left slot's overflow, pin the right slot so the buttons keep their natural width, and ellipsize the default header title.
mrmeghana
enabled auto-merge (squash)
August 14, 2026 12:14
Contributor
Author
|
Closing: per review on Countly/countly-platform#1072, the fix is being scoped to a funnel-specific class instead of the shared |
auto-merge was automatically disabled
August 14, 2026 13:09
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On report detail pages (e.g. a funnel), a very long title/name displayed in the shared
cly-headeroverlaps the action buttons on the right (Edit / more-options). Becausecly-headeris reused across reports, the issue appears in all of them.Root cause
The header's mid-level row is a flex row: a shrinkable left slot (
bu-is-flex-shrink-1+ inlinemin-width:0) next to the right-side buttons. The left slot had nooverflowhandling, so overflowing content bled over the right slot instead of being clipped, and nothing pinned the buttons.Fix
In
_header.scss, for.cly-vue-header__level:flex-shrink: 0) with a 16px gap so the action buttons keep their natural width and position;<h2>title.This stops the overlap in every report using
cly-header. Plugins with a customheader-left(e.g. funnels) additionally get proper ellipsis via their own small change.Testing
Verified the compiled rules land in
manifest.cssand confirmed the flex/truncation behavior in an isolated reproduction of the header DOM (long name → ellipsis, buttons stay put; short name unchanged).