Conversation
[pull] dev from CyberDrain:dev
[pull] dev from CyberDrain:dev
[pull] dev from CyberDrain:dev
[pull] dev from CyberDrain:dev
[pull] dev from CyberDrain:dev
[pull] dev from CyberDrain:dev
[pull] dev from CyberDrain:dev
[pull] dev from CyberDrain:dev
[pull] dev from CyberDrain:dev
[pull] dev from CyberDrain:dev
[pull] dev from CyberDrain:dev
[pull] dev from CyberDrain:dev
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Setup-Windows-Chrome-and-Edge.ps1searches the downloaded templates forbut both
Deploy-Windows-Chrome-and-Edge.ps1andDetect-Windows-Chrome-and-Edge.ps1ship the setting as= 0 #.Apply-Replacementsmatches withString.Contains, so the lookup misses, the pattern lands in$missing, and the script throws before writing any output files:This fails for every user regardless of the answers given at the prompts — it is the only one of the 23 patterns that does not match. Since
$baseUrlis pinned torefs/heads/main, the templates are always fetched frommain, so no local copy of Setup can work around it.Fix
One line: correct the search pattern to
= 0 #so it matches what the templates actually ship.Verification
Ran the full replacement block from the fixed Setup against the current
DeployandDetecttemplates:companyNameandcippTenantId, wildcards inurlAllowlist, multi-elementwebhookEvents). Quote escaping viaFormat-SingleQuoted/Format-ArrayLiteralis correct.domainSquatting,urlAllowlist,customBranding,genericWebhookandgenericWebhook\eventssubkeys and the browser-specific toolbar property. Nothing is written-but-unchecked or checked-but-unwritten.No changes to Deploy, Detect or Remove.
🤖 Generated with Claude Code