-
-
Notifications
You must be signed in to change notification settings - Fork 66
feat: add isExternal property to Component for CycloneDX v1.7 #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6119806
feat: add isExternal property to Component for CycloneDX v1.7
tonal 361f7a7
Merge branch 'main' into main
tonal babaa45
Merge branch 'main' into main
tonal 4906056
Update cyclonedx/serialization/__init__.py
jkowalleck 430da44
Apply suggestion from @jkowalleck
jkowalleck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
tests/_data/snapshots/get_bom_with_external_component_1_7-1.0.xml.bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <?xml version="1.0" ?> | ||
| <bom xmlns="http://cyclonedx.org/schema/bom/1.0" version="1"> | ||
| <components> | ||
| <component type="library"> | ||
| <name>external-lib</name> | ||
| <version>1.0.0</version> | ||
| <scope>required</scope> | ||
| <modified>false</modified> | ||
| </component> | ||
| </components> | ||
| </bom> |
10 changes: 10 additions & 0 deletions
10
tests/_data/snapshots/get_bom_with_external_component_1_7-1.1.xml.bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <?xml version="1.0" ?> | ||
| <bom xmlns="http://cyclonedx.org/schema/bom/1.1" serialNumber="urn:uuid:1441d33a-e0fc-45b5-af3b-61ee52a88bac" version="1"> | ||
| <components> | ||
| <component type="library" bom-ref="external-lib-1.0.0"> | ||
| <name>external-lib</name> | ||
| <version>1.0.0</version> | ||
| <scope>required</scope> | ||
| </component> | ||
| </components> | ||
| </bom> |
24 changes: 24 additions & 0 deletions
24
tests/_data/snapshots/get_bom_with_external_component_1_7-1.2.json.bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "components": [ | ||
| { | ||
| "bom-ref": "external-lib-1.0.0", | ||
| "name": "external-lib", | ||
| "scope": "required", | ||
| "type": "library", | ||
| "version": "1.0.0" | ||
| } | ||
| ], | ||
| "dependencies": [ | ||
| { | ||
| "ref": "external-lib-1.0.0" | ||
| } | ||
| ], | ||
| "metadata": { | ||
| "timestamp": "2023-01-07T13:44:32.312678+00:00" | ||
| }, | ||
| "serialNumber": "urn:uuid:1441d33a-e0fc-45b5-af3b-61ee52a88bac", | ||
| "version": 1, | ||
| "$schema": "http://cyclonedx.org/schema/bom-1.2b.schema.json", | ||
| "bomFormat": "CycloneDX", | ||
| "specVersion": "1.2" | ||
| } |
16 changes: 16 additions & 0 deletions
16
tests/_data/snapshots/get_bom_with_external_component_1_7-1.2.xml.bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?xml version="1.0" ?> | ||
| <bom xmlns="http://cyclonedx.org/schema/bom/1.2" serialNumber="urn:uuid:1441d33a-e0fc-45b5-af3b-61ee52a88bac" version="1"> | ||
| <metadata> | ||
| <timestamp>2023-01-07T13:44:32.312678+00:00</timestamp> | ||
| </metadata> | ||
| <components> | ||
| <component type="library" bom-ref="external-lib-1.0.0"> | ||
| <name>external-lib</name> | ||
| <version>1.0.0</version> | ||
| <scope>required</scope> | ||
| </component> | ||
| </components> | ||
| <dependencies> | ||
| <dependency ref="external-lib-1.0.0"/> | ||
| </dependencies> | ||
| </bom> |
24 changes: 24 additions & 0 deletions
24
tests/_data/snapshots/get_bom_with_external_component_1_7-1.3.json.bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "components": [ | ||
| { | ||
| "bom-ref": "external-lib-1.0.0", | ||
| "name": "external-lib", | ||
| "scope": "required", | ||
| "type": "library", | ||
| "version": "1.0.0" | ||
| } | ||
| ], | ||
| "dependencies": [ | ||
| { | ||
| "ref": "external-lib-1.0.0" | ||
| } | ||
| ], | ||
| "metadata": { | ||
| "timestamp": "2023-01-07T13:44:32.312678+00:00" | ||
| }, | ||
| "serialNumber": "urn:uuid:1441d33a-e0fc-45b5-af3b-61ee52a88bac", | ||
| "version": 1, | ||
| "$schema": "http://cyclonedx.org/schema/bom-1.3a.schema.json", | ||
| "bomFormat": "CycloneDX", | ||
| "specVersion": "1.3" | ||
| } |
16 changes: 16 additions & 0 deletions
16
tests/_data/snapshots/get_bom_with_external_component_1_7-1.3.xml.bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?xml version="1.0" ?> | ||
| <bom xmlns="http://cyclonedx.org/schema/bom/1.3" serialNumber="urn:uuid:1441d33a-e0fc-45b5-af3b-61ee52a88bac" version="1"> | ||
| <metadata> | ||
| <timestamp>2023-01-07T13:44:32.312678+00:00</timestamp> | ||
| </metadata> | ||
| <components> | ||
| <component type="library" bom-ref="external-lib-1.0.0"> | ||
| <name>external-lib</name> | ||
| <version>1.0.0</version> | ||
| <scope>required</scope> | ||
| </component> | ||
| </components> | ||
| <dependencies> | ||
| <dependency ref="external-lib-1.0.0"/> | ||
| </dependencies> | ||
| </bom> |
24 changes: 24 additions & 0 deletions
24
tests/_data/snapshots/get_bom_with_external_component_1_7-1.4.json.bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "components": [ | ||
| { | ||
| "bom-ref": "external-lib-1.0.0", | ||
| "name": "external-lib", | ||
| "scope": "required", | ||
| "type": "library", | ||
| "version": "1.0.0" | ||
| } | ||
| ], | ||
| "dependencies": [ | ||
| { | ||
| "ref": "external-lib-1.0.0" | ||
| } | ||
| ], | ||
| "metadata": { | ||
| "timestamp": "2023-01-07T13:44:32.312678+00:00" | ||
| }, | ||
| "serialNumber": "urn:uuid:1441d33a-e0fc-45b5-af3b-61ee52a88bac", | ||
| "version": 1, | ||
| "$schema": "http://cyclonedx.org/schema/bom-1.4.schema.json", | ||
| "bomFormat": "CycloneDX", | ||
| "specVersion": "1.4" | ||
| } |
16 changes: 16 additions & 0 deletions
16
tests/_data/snapshots/get_bom_with_external_component_1_7-1.4.xml.bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?xml version="1.0" ?> | ||
| <bom xmlns="http://cyclonedx.org/schema/bom/1.4" serialNumber="urn:uuid:1441d33a-e0fc-45b5-af3b-61ee52a88bac" version="1"> | ||
| <metadata> | ||
| <timestamp>2023-01-07T13:44:32.312678+00:00</timestamp> | ||
| </metadata> | ||
| <components> | ||
| <component type="library" bom-ref="external-lib-1.0.0"> | ||
| <name>external-lib</name> | ||
| <version>1.0.0</version> | ||
| <scope>required</scope> | ||
| </component> | ||
| </components> | ||
| <dependencies> | ||
| <dependency ref="external-lib-1.0.0"/> | ||
| </dependencies> | ||
| </bom> |
34 changes: 34 additions & 0 deletions
34
tests/_data/snapshots/get_bom_with_external_component_1_7-1.5.json.bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "components": [ | ||
| { | ||
| "bom-ref": "external-lib-1.0.0", | ||
| "name": "external-lib", | ||
| "scope": "required", | ||
| "type": "library", | ||
| "version": "1.0.0" | ||
| } | ||
| ], | ||
| "dependencies": [ | ||
| { | ||
| "ref": "external-lib-1.0.0" | ||
| } | ||
| ], | ||
| "metadata": { | ||
| "timestamp": "2023-01-07T13:44:32.312678+00:00" | ||
| }, | ||
| "properties": [ | ||
| { | ||
| "name": "key1", | ||
| "value": "val1" | ||
| }, | ||
| { | ||
| "name": "key2", | ||
| "value": "val2" | ||
| } | ||
| ], | ||
| "serialNumber": "urn:uuid:1441d33a-e0fc-45b5-af3b-61ee52a88bac", | ||
| "version": 1, | ||
| "$schema": "http://cyclonedx.org/schema/bom-1.5.schema.json", | ||
| "bomFormat": "CycloneDX", | ||
| "specVersion": "1.5" | ||
| } |
20 changes: 20 additions & 0 deletions
20
tests/_data/snapshots/get_bom_with_external_component_1_7-1.5.xml.bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| <?xml version="1.0" ?> | ||
| <bom xmlns="http://cyclonedx.org/schema/bom/1.5" serialNumber="urn:uuid:1441d33a-e0fc-45b5-af3b-61ee52a88bac" version="1"> | ||
| <metadata> | ||
| <timestamp>2023-01-07T13:44:32.312678+00:00</timestamp> | ||
| </metadata> | ||
| <components> | ||
| <component type="library" bom-ref="external-lib-1.0.0"> | ||
| <name>external-lib</name> | ||
| <version>1.0.0</version> | ||
| <scope>required</scope> | ||
| </component> | ||
| </components> | ||
| <dependencies> | ||
| <dependency ref="external-lib-1.0.0"/> | ||
| </dependencies> | ||
| <properties> | ||
| <property name="key1">val1</property> | ||
| <property name="key2">val2</property> | ||
| </properties> | ||
| </bom> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.