Skip to content

fix: allow protocol related cryptographic assets in XML - #1020

Closed
CAOShurong wants to merge 1 commit into
CycloneDX:masterfrom
CAOShurong:codex/fix-protocol-crypto-assets-xsd
Closed

fix: allow protocol related cryptographic assets in XML#1020
CAOShurong wants to merge 1 commit into
CycloneDX:masterfrom
CAOShurong:codex/fix-protocol-crypto-assets-xsd

Conversation

@CAOShurong

Copy link
Copy Markdown

Summary

  • allow XML protocolProperties to use the preferred relatedCryptographicAssets representation already available in JSON Schema and Protobuf
  • extend the full cryptography fixtures in XML, JSON, and textproto so the field stays covered across formats

Fixes #1018.

Verification

  • reproduced the regression before the XSD change: the Java XML suite reported only 1.7/valid-cryptography-full-1.7.xml failing
  • mvn clean test (769 tests)
  • npm test on Linux with Node 24
  • Buf 1.58.0 lint, remote and adjacent-version breaking checks, plus all 193 valid textproto fixtures
  • PHP JSON/XML schema scripts for every supported version
  • docgen/xml/gen.sh for XML documentation versions 1.0 through 1.7; the generated 1.7 reference includes the new element

AI assistance

OpenAI Codex assisted with repository research, implementation, and test execution. I reviewed the change and its generated output, reproduced the failure before the fix, ran the validations above, and take responsibility for the contribution.

Allow protocol properties to use the preferred relatedCryptographicAssets representation already supported by JSON Schema and Protobuf. Extend the full cryptography fixtures across all three formats to cover the field.

Signed-off-by: Shurong Cao <170531907+CAOShurong@users.noreply.github.com>
@CAOShurong

Copy link
Copy Markdown
Author

Closing this in favor of #1019, which predates this PR and implements the same schema fix with clearer cryptoRef deprecation text.

I independently tested #1019 at 63cda281ab834726ca1b80c480fa9edf9693d4f0 (769 Java tests, the full Node 24 JSON suite, Buf schema lint, and the modified 1.7 textproto fixture) and submitted an approving review there. Keeping both PRs open would only duplicate maintainer work.

@CAOShurong CAOShurong closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Defect]: 1.7 XML schema omits protocol relatedCryptographicAssets

1 participant