fix: allow protocol related cryptographic assets in XML - #1020
Closed
CAOShurong wants to merge 1 commit into
Closed
Conversation
Allow protocol properties to use the preferred relatedCryptographicAssets representation already supported by JSON Schema and Protobuf. Extend the full cryptography fixtures across all three formats to cover the field. Signed-off-by: Shurong Cao <170531907+CAOShurong@users.noreply.github.com>
Author
|
Closing this in favor of #1019, which predates this PR and implements the same schema fix with clearer I independently tested #1019 at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protocolPropertiesto use the preferredrelatedCryptographicAssetsrepresentation already available in JSON Schema and ProtobufFixes #1018.
Verification
1.7/valid-cryptography-full-1.7.xmlfailingmvn clean test(769 tests)npm teston Linux with Node 24docgen/xml/gen.shfor XML documentation versions 1.0 through 1.7; the generated 1.7 reference includes the new elementAI assistance
OpenAI Codex assisted with repository research, implementation, and test execution. I reviewed the change and its generated output, reproduced the failure before the fix, ran the validations above, and take responsibility for the contribution.