2.0 dev fix bundler result schema name - #1027
Open
jkowalleck wants to merge 2 commits into
Open
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the bundler produced files
but it did not set the proper
$idfor these output files.it kept them untouched. leading to possible errors downstream.
background:
the original schema
cyclonedx-api-2.0.schema.jsondefined an id.that one was reused in those bundled schemas which actually were not congruent, though they might have validated the same structure:
$defs/cyclonedx-...-2.0/that thecyclonedx-api-2.0.schema.jsondid not have.cyclonedx-api-2.0.schema.jsonfor the original id, you could not access those$defsthat were in a bundle.since they were not interchangeable, the id must be different.
motivation:
i could write an own validator based on cyclonedx, where i would reuse the $devs provided by the schema.
if i switched from the minified/bundled version to the original one, it would break, even though both claim to be interchangeable since they have the same schema.