docs(rtd): fix broken 404-page asset paths - #1026
Draft
kjvbrt wants to merge 2 commits into
Draft
Conversation
aldbr
requested changes
Sep 2, 2026
aldbr
left a comment
aldbr
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Since there is no attached issue and Definition of Done here, could you take the opportunity to replace diracx.io everywhere?
I still see 2 occurrences of it in the documentation.
Thanks! 🙂
DIRACGridBot
marked this pull request as draft
September 2, 2026 07:34
Contributor
Author
|
Yes, it's done now. |
site_url pointed at an unused domain with no path, so mkdocs emitted root-absolute asset links on 404.html/sitemap.xml. Those 404 under Read the Docs' /en/latest/ prefix, leaving the 404 page unstyled. Use mkdocs's built-in !ENV tag to pick up READTHEDOCS_CANONICAL_URL at build time, falling back to a static default for local builds.
Addresses review feedback on this PR — 2 leftover references to the old, unused domain.
kjvbrt
force-pushed
the
fix/404-page-site-url
branch
from
September 3, 2026 07:23
d9eaaf8 to
36d3814
Compare
Contributor
Author
|
PR #1027 needs to be merged first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
site_urlpointed at an unused domain with no path, so mkdocs generated root-absolute asset links for version-less pages like 404.html. Read the Docs serves this project under a /en/latest/ prefix, so those requests 404 and the 404 page renders unstyled.Fixed via mkdocs's built-in !ENV tag, which picks up Read the Docs' READTHEDOCS_CANONICAL_URL at build time and falls back to a static default locally. No new dependency needed.