Enhance e2e (end-to-end) tests for MyDSpace page (Part 2)

[oscar-escire]

References

• Fixes Enhance e2e (end-to-end) tests for MyDSpace page #3985 (Second part)

Description

This PR includes three new tests for the My-DSpace page. Specifically, the three new tests are:

• Start a new Submission of various types using the "+" dropdown
• Start a new Submission of various types using the "import" dropdown
• Test the "see", "return to pool", "edit", "reject" and "approve" workflow items buttons
• Test actions in supervised item view

Instructions for Reviewers

1. Start DSpace in dev mode
2. Open Cypress with (cypress:run)
3. Run the my-dspace.ts tests and you will see the three new tests in the list.

List of changes in this PR:

• Added describe section for testing supervised items to my-dspace.cy.ts file
• Added describe section for testing workflow tasks to my-dspace.cy.ts file
• Added describe section for testing import external items to my-dspace.cy.ts file
• Added describe section for testing new submissions button to my-dspace.cy.ts file

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[github-actions]

Hi @oscar-escire,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[EikLoe]

Hi @oscar-escire ,
I could take a look at this PR, if you want, because I'm working on serveral e2e tests as well. Could you therefore resolve merge conflicts?

[oscar-escire]

@EikLoe: Thanks! I've resolved the conflicts and updated the branch with the latest changes, but it seems a random error occurred during the build

[EikLoe]

Thanks for your PR and all these additional tests for the my-dspace page. Unfortunately there are some errors caused by the recent updates from #5937. Could you replace all your uses of Cypress.env() as I described?

[oscar-escire]

@EikLoe and @tdonohue: I've updated the code based on @EikLoe's comments; however, I've noticed that in both the development environments and the backend initialized on GitHub, the option to import a person from external sources has been disabled. In this case, will this change be made permanent? If so, I think the best course of action would be to remove the test that validated this option.

[tdonohue]

@oscar-escire : The option to import a Person from an external source should not be disabled. It exists on our Sandbox (https://sandbox.dspace.org) site and our Demo (https://demo.dspace.org) site. I'm not sure why it wouldn't be enabled in the e2e tests, but that may require further investigation. (Unfortunately, I may not have time to dig deeper until late next week at the earliest)

[oscar-escire]

@tdonohue: Thanks, I'm taking a look at the demo site. It seems that user “dspacedemo+submit@gmail.com” isn't assigned as a submitter for the “People” collection. This setting appears to come from the test data, so I'm not sure how to resolve the issue.

[tdonohue]

@oscar-escire : in the test data, the dspacedemo+submit@gmail.com account is only able to submit Publication entities and traditional Items. But, it looks like there are other submitter accounts for other entity types (at least that's what I see on Sandbox/Demo);

• dspacedemo+submitorgunit@gmail.com -> can submit OrgUnit entity type
• dspacedemo+submitperson@gmail.com -> can submit Person entity type
• dspacedemo+submitissue@gmail.com -> can submit Journal Issue entity type
• dspacedemo+submitvolume@gmail.com -> can submit Journal Volume entity type

Those are all of the submitter accounts we seem to have in the test data set. But, you could use the Admin account to test submissions of other types of Entities (because it has access to submit all entity types).