Skip to content

Allow scope selector to be hidden by config in tabbed entities search - #6190

Open
MarieVerdonck wants to merge 2 commits into
DSpace:mainfrom
atmire:allow-scope-config-in-tabbed-entities-search-main
Open

Allow scope selector to be hidden by config in tabbed entities search#6190
MarieVerdonck wants to merge 2 commits into
DSpace:mainfrom
atmire:allow-scope-config-in-tabbed-entities-search-main

Conversation

@MarieVerdonck

@MarieVerdonck MarieVerdonck commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

This PR makes the visibility of the search scope selector configurable for related entities searches on simple item pages.

Instructions for Reviewers

The showScopeSelector input is exposed on:

  • RelatedEntitiesSearchComponent
  • TabbedRelatedEntitiesSearchComponent

and passed through to the underlying ConfigurationSearchPageComponent.

How to test

Set [showScopeSelector]="false" on a tabbed related entities search and verify the scope selector is hidden.
Eg in src/app/entity-groups/research-entities/item-pages/org-unit/org-unit.component.html in ds-tabbed-related-entities-search
=> Verify on OrgUnit simple item page the search doesn't have selector, but on e.g. Person entity simple item page it does

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

…tabbed related entities used on simple item pages for related items search
…allow-scope-config-in-tabbed-entities-search-main

# Conflicts:
#	src/app/item-page/simple/related-entities/related-entities-search/related-entities-search.component.html
#	src/app/item-page/simple/related-entities/tabbed-related-entities-search/tabbed-related-entities-search.component.html
@MarieVerdonck
MarieVerdonck marked this pull request as ready for review September 7, 2026 20:44
@MarieVerdonck MarieVerdonck changed the title Allow scope config in tabbed entities search Allow scope selector to be hidden by config in tabbed entities search Sep 7, 2026
@lgeggleston lgeggleston added component: Discovery related to discovery search or browse system configuration 1 APPROVAL pull request only requires a single approval to merge ux User Experience related works labels Sep 8, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Sep 8, 2026
@lgeggleston lgeggleston added the component: Item (Archived) Item display or editing label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: Discovery related to discovery search or browse system component: Item (Archived) Item display or editing configuration ux User Experience related works

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

2 participants