fix: fix logo upload handling - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
应用中心上传 logo 在部署环境会报错:
the multipart request can't be consumed twice原因是全局
multipart已配置为mode: file,请求进入控制器前文件已经落到临时目录,但uploadLogo仍然使用ctx.getFileStream()再次读取请求体,导致 multipart 被二次消费。改动
app/controller/appCenters.js的uploadLogo从ctx.getFileStream()改为读取ctx.request.files影响范围
POST /api/appCenters/upload-logo/:id验证
the multipart request can't be consumed twicelogoUrl风险说明