Fix integration test, no longer producing ADC patterns for CRT - #337
Open
xinyue-uoft wants to merge 1 commit into
Open
Fix integration test, no longer producing ADC patterns for CRT#337xinyue-uoft wants to merge 1 commit into
xinyue-uoft wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See DUNE-DAQ/datahandlinglibs#145 .
datahandlinglibsfunctiongenerate_periodic_adc_patternis currently trying to distribute ADC pattern over 64 frames over CRT which has only 32 frames. Only thing preventing an runtime error is a blind try-catch statement. The correct behaviour should be that ADC pattern generation for CRTs should not be there in the first place. This PR changes it at integration test config substitution level to disable ADC pattern generation on CRT.Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)