Re-enable DateOnly/TimeOnly support, fixing the defects that got it disabled - #2228
Merged
Conversation
…isabled DateOnly/TimeOnly support (#2051) was compiled out in 907a4d9 pending #2071/#2072. This re-enables it with the root causes fixed, and teaches the read paths that the date/time family has no IConvertible bridge - which box a date or time column yields is a provider/version decision (Npgsql 10: DateOnly/TimeOnly; SqlClient and Npgsql 9: DateTime/TimeSpan), so both shapes must convert: - GetFieldValue<T> is no longer demanded of a column whose reported type needs a family conversion (a datetime column into a DateOnly member was the #2072 breakage; SqlDecimal-style entries, where GetFieldValue from a differently-reported column is the whole point, keep it); - the member, scalar and Parse<T> paths all convert DateOnly/TimeOnly <-> DateTime/TimeSpan in both directions (IL for members, object-level elsewhere), fixing reads against Npgsql 10 date/time columns (#2226); - Query<DateOnly>/<TimeOnly> in scalar form no longer silently return default(T) (#2227): the typeMap entries make them simple types again; - the same-TypeCode direct-unbox shortcut is restricted to distinct codes: TypeCode.Object matching TypeCode.Object says nothing (TimeSpan into TimeOnly? threw), while object on either side (sql_variant columns, dynamic members) keeps the direct unbox; - the scalar conversion fallback keeps Convert.ChangeType's strict null contract (TestConversionExceptionMessages pins it). The parked DateTimeOnlyTests are re-enabled, with new tests for the #2072 shape (datetime column into DateOnly member), the #2227 scalar shape, and date-as-DateTime regression guards; PostgresqlTests gains the Npgsql-10 interchange matrix ([FactPostgresql], so it runs where the documented container is available). Fixes #2072, #2226, #2227, #1728; expected to also resolve #2071.
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DateOnly/TimeOnly support (#2051) was compiled out in 907a4d9 pending #2071/#2072. This re-enables it with the root causes fixed, and teaches the read paths that the date/time family has no
IConvertiblebridge — which box adate/timecolumn yields is a provider/version decision (Npgsql 10:DateOnly/TimeOnly; SqlClient and Npgsql 9:DateTime/TimeSpan), so both shapes must convert:GetFieldValue<T>is no longer demanded of a column whose reported type needs a family conversion — adatetimecolumn into aDateOnlymember was the DateOnly "off by one" column error #2072 breakage.SqlDecimal-style entries, whereGetFieldValuefrom a differently-reported column is the whole point, keep it.Parse<T>paths all convertDateOnly/TimeOnly↔DateTime/TimeSpanin both directions, fixing reads against Npgsql 10 date/time columns (DateOnly/DateTime coercion gaps on 'date' columns (breaks with Npgsql 10, and SqlClient the other way) #2226).Query<DateOnly>/<TimeOnly>in scalar form no longer silently returndefault(T)(Query<DateOnly> / Query<TimeOnly> (scalar form) silently return default(T) #2227).TypeCodedirect-unbox shortcut now requires distinct codes:TypeCode.ObjectmatchingTypeCode.Objectsays nothing (TimeSpanintoTimeOnly?threw), while object on either side —sql_variantcolumns,dynamicmembers — keeps the direct unbox.Convert.ChangeType's strict null contract (TestConversionExceptionMessagespins it).Verified with a 13-probe matrix across SqlClient and both Npgsql 9.0.2/10.0.2 (all green, both directions, nullable included, plus the exact #2072 repro shape), and the full test suite passes on net10/net8/net481 against local SQL Server + the documented Postgres container. The parked
DateTimeOnlyTestsare re-enabled with new tests for the #2072 and #2227 shapes and date-as-DateTime regression guards;PostgresqlTestsgains the Npgsql-10 interchange matrix.Fixes #2072, #2226, #2227, #1728; expected to also resolve #2071 (same family — would appreciate confirmation from that repro).