Skip to content

Avoid null collection on decoded spans - #12087

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
bbujon/smoke-tests-decoded-spans
Jul 30, 2026
Merged

Avoid null collection on decoded spans#12087
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
bbujon/smoke-tests-decoded-spans

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

This PR updates the decoded spans to avoid null collections.

Motivation

This changes will help asserting the trace / span structure and values with the upcoming rules and matchers.

Additional Notes

Contributor Checklist

Jira ticket: APMLP-1247

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74c157ccdf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The decoder changes consistently replace absent meta_struct values with immutable empty maps across v0.4, v0.5, and v1, matching the updated smoke-test assertions. No diff-only behavioral regression was identified; local execution was attempted but the sandbox lacks the required Gradle distribution and Java 25 toolchain.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 74c157c · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 0.00%
Overall Coverage: 57.83% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a6e2545 | Docs | Datadog PR Page | Give us feedback!

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-decoded-spans branch from 74c157c to d1a2872 Compare July 28, 2026 09:09
@dd-octo-sts

dd-octo-sts Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 14.02 s [-0.6%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.96 s 13.02 s [-1.2%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 16.39 s 16.83 s [-6.9%; +1.6%] (no difference)
startup:petclinic:iast:Agent 16.73 s 16.83 s [-1.4%; +0.2%] (no difference)
startup:petclinic:profiling:Agent 16.80 s 16.11 s [-0.2%; +8.8%] (no difference)
startup:petclinic:sca:Agent 16.79 s 16.71 s [-0.6%; +1.5%] (no difference)
startup:petclinic:tracing:Agent 15.97 s 16.08 s [-1.7%; +0.3%] (no difference)

Commit: a6e25453 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@jandro996 jandro996 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-test-agent branch from 775ec98 to 2edebf3 Compare July 30, 2026 04:16
@PerfectSlayer
PerfectSlayer requested review from a team as code owners July 30, 2026 04:16
@PerfectSlayer
PerfectSlayer requested review from amarziali and randomanderson and removed request for a team July 30, 2026 04:16
@PerfectSlayer
PerfectSlayer force-pushed the bbujon/smoke-tests-decoded-spans branch from d1a2872 to a6e2545 Compare July 30, 2026 04:17
@PerfectSlayer

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 30, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-30 04:24:28 UTC ℹ️ Start processing command /merge


2026-07-30 04:24:30 UTC ℹ️ MergeQueue: Stack detected — automatically merging the entire stack.


2026-07-30 04:24:34 UTC ℹ️ Devflow: Merging stacked PRs in the following order:

  1. Add test agent session token support (#12050)
  2. Avoid null collection on decoded spans (#12087)

Progress updates will be sent here directly.


2026-07-30 04:24:35 UTC ℹ️ Devflow: Merging Add test agent session token support (#12050)...


2026-07-30 04:24:38 UTC ❌ MergeQueue

merge method 'merge' is not allowed for this repository. Supported methods are: [squash]

Base automatically changed from bbujon/smoke-tests-test-agent to master July 30, 2026 05:55
@PerfectSlayer

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 30, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-30 05:55:42 UTC ℹ️ Start processing command /merge


2026-07-30 05:55:47 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-07-30 06:59:03 UTC ℹ️ MergeQueue: This merge request was merged

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The decoder changes consistently normalize absent meta-struct data to immutable empty maps across v0.4, v0.5, and v1, matching the updated smoke-test consumers without changing populated values. No diff-only behavioral regression was identified; local execution was blocked by the unavailable Gradle wrapper network and Java 25 toolchain.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit a6e2545 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit a86b3de into master Jul 30, 2026
586 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bbujon/smoke-tests-decoded-spans branch July 30, 2026 06:59
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants