Skip to content

Support Robolectric 4.17 test metadata - #12478

Open
AlexeyKuznetsov-DD wants to merge 3 commits into
masterfrom
alexeyk/fix-robolectric-4-17-muzzle
Open

Support Robolectric 4.17 test metadata#12478
AlexeyKuznetsov-DD wants to merge 3 commits into
masterfrom
alexeyk/fix-robolectric-4-17-muzzle

Conversation

@AlexeyKuznetsov-DD

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

  • Updates Robolectric test metadata collection for Robolectric 4.17 by reading the Android release and API level from android.os.Build.
  • Preserves the short test.android.codename value (U, V, and so on) by matching SDK_INT to the public Build.VERSION_CODES fields.
  • Adds the Robolectric Android 14 SDK artifact as a compile-time and muzzle dependency.
  • Updates the Gradle daemon smoke fixture and expected events to Robolectric 4.17.

Motivation

Robolectric 4.17 removed org.robolectric.versioning.AndroidVersions. Because the instrumentation's muzzle range is open-ended, validation began resolving 4.17 and failed deterministically:

FAILED MUZZLE VALIDATION: RobolectricInstrumentation mismatches:
-- RobolectricTestAnnotator: Missing class org.robolectric.versioning.AndroidVersions

Using the Android SDK classes that Robolectric exposes avoids the removed internal API while preserving the existing CI Visibility metadata values.

Additional Notes

Validation:

  • ./gradlew :dd-java-agent:instrumentation:robolectric-4.13:muzzle :dd-java-agent:instrumentation:robolectric-4.13:spotlessCheck
  • ./gradlew :dd-smoke-tests:gradle:spotlessCheck
  • ./gradlew :dd-smoke-tests:gradle:test --tests datadog.smoketest.GradleDaemonSmokeTest.testRobolectric (the existing JDK 17-21 guard skipped the scenario on JDK 25)

Relevant precedent: #11852

Contributor Checklist

Jira ticket: N/A

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM labels Sep 13, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 13, 2026

Copy link
Copy Markdown

Test Environment - netflix-zuul

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 38.13 87.80 $\color{green}{\blacktriangledown}$ -49.67 87.80 $\color{green}{\blacktriangledown}$ -49.67 23/94
agentless 31.32 81.05 $\color{green}{\blacktriangledown}$ -49.73 81.05 $\color{green}{\blacktriangledown}$ -49.73 22/93
agentlessCodeCoverage 40.99 95.12 $\color{green}{\blacktriangledown}$ -54.13 95.12 $\color{green}{\blacktriangledown}$ -54.13 22/93
agentlessLineCoverage 52.62 111.62 $\color{green}{\blacktriangledown}$ -59.00 111.62 $\color{green}{\blacktriangledown}$ -59.00 22/96

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 13, 2026

Copy link
Copy Markdown

Test Environment - sbt-scalatest

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 55.41 55.43 $\color{green}{\blacktriangledown}$ -0.02 55.43 $\color{green}{\blacktriangledown}$ -0.02 40/182
agentEvpProxy 54.44 n/a n/a n/a n/a -

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 13, 2026

Copy link
Copy Markdown

Test Environment - reactive-streams-jvm

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 11.25 21.65 $\color{green}{\blacktriangledown}$ -10.40 21.65 $\color{green}{\blacktriangledown}$ -10.40 31/107
agentless 8.99 19.20 $\color{green}{\blacktriangledown}$ -10.21 19.20 $\color{green}{\blacktriangledown}$ -10.21 26/99
agentlessCodeCoverage 8.44 19.59 $\color{green}{\blacktriangledown}$ -11.15 19.99 $\color{green}{\blacktriangledown}$ -11.55 26/97
agentlessLineCoverage 14.49 26.98 $\color{green}{\blacktriangledown}$ -12.49 26.98 $\color{green}{\blacktriangledown}$ -12.49 15/56

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 13, 2026

Copy link
Copy Markdown

Test Environment - pass4s

Job Status: 🔴 failed

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 13, 2026

Copy link
Copy Markdown

Test Environment - heliboard

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent -14.99 10.33 $\color{green}{\blacktriangledown}$ -25.32 10.13 $\color{green}{\blacktriangledown}$ -25.12 21/91

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 13, 2026

Copy link
Copy Markdown

Test Environment - okhttp

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent -0.88 19.99 $\color{green}{\blacktriangledown}$ -20.87 19.99 $\color{green}{\blacktriangledown}$ -20.87 20/90
agentless -1.60 19.20 $\color{green}{\blacktriangledown}$ -20.80 19.20 $\color{green}{\blacktriangledown}$ -20.80 21/89
agentlessCodeCoverage 1.78 22.54 $\color{green}{\blacktriangledown}$ -20.76 22.54 $\color{green}{\blacktriangledown}$ -20.76 20/89
agentlessLineCoverage 13.88 38.67 $\color{green}{\blacktriangledown}$ -24.79 38.67 $\color{green}{\blacktriangledown}$ -24.79 20/90

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 13, 2026

Copy link
Copy Markdown

Test Environment - nebula-release-plugin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent -52.90 36.42 $\color{green}{\blacktriangledown}$ -89.32 36.42 $\color{green}{\blacktriangledown}$ -89.32 24/95
agentless -53.31 35.70 $\color{green}{\blacktriangledown}$ -89.01 35.70 $\color{green}{\blacktriangledown}$ -89.01 24/95
agentlessCodeCoverage -50.20 44.48 $\color{green}{\blacktriangledown}$ -94.68 44.48 $\color{green}{\blacktriangledown}$ -94.68 24/95
agentlessLineCoverage -46.30 55.43 $\color{green}{\blacktriangledown}$ -101.73 55.43 $\color{green}{\blacktriangledown}$ -101.73 24/95

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 13, 2026

Copy link
Copy Markdown

Test Environment - sonar-kotlin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent -39.48 13.13 $\color{green}{\blacktriangledown}$ -52.61 13.13 $\color{green}{\blacktriangledown}$ -52.61 30/96
agentless -39.99 11.65 $\color{green}{\blacktriangledown}$ -51.64 11.88 $\color{green}{\blacktriangledown}$ -51.87 24/90
agentlessCodeCoverage -37.65 14.81 $\color{green}{\blacktriangledown}$ -52.46 15.11 $\color{green}{\blacktriangledown}$ -52.76 24/90
agentlessLineCoverage -36.54 17.73 $\color{green}{\blacktriangledown}$ -54.27 17.73 $\color{green}{\blacktriangledown}$ -54.27 24/90

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@datadog-datadog-prod-us1

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.74 s 14.66 s [-0.4%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent 13.56 s 13.70 s [-1.9%; -0.1%] (maybe better)
startup:petclinic:appsec:Agent 17.58 s 17.28 s [+0.8%; +2.6%] (maybe worse)
startup:petclinic:iast:Agent 16.85 s 17.51 s [-7.9%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 17.38 s 17.13 s [+0.4%; +2.6%] (maybe worse)
startup:petclinic:sca:Agent 17.58 s 17.35 s [+0.4%; +2.3%] (maybe worse)
startup:petclinic:tracing:Agent 16.46 s 16.60 s [-2.0%; +0.4%] (no difference)

Commit: 0c0fbfd2 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review September 13, 2026 03:14
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from a team as code owners September 13, 2026 03:14
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from amarziali and ygree and removed request for a team September 13, 2026 03:14
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Sep 13, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-13T03:16:38.805981Z c2221fc Draft marked ready
🔒 Security Review Completed 2026-09-13T03:17:51.398558Z c2221fc Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 13, 2026

Copy link
Copy Markdown

Test Environment - jolokia

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 92.81 93.23 $\color{green}{\blacktriangledown}$ -0.42 95.12 $\color{green}{\blacktriangledown}$ -2.31 27/105
agentless 87.57 89.58 $\color{green}{\blacktriangledown}$ -2.01 89.58 $\color{green}{\blacktriangledown}$ -2.01 26/103
agentlessCodeCoverage 96.28 99.00 $\color{green}{\blacktriangledown}$ -2.72 99.00 $\color{green}{\blacktriangledown}$ -2.72 26/101
agentlessLineCoverage 96.23 99.00 $\color{green}{\blacktriangledown}$ -2.77 99.00 $\color{green}{\blacktriangledown}$ -2.77 27/105

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

The new codename mapping changes API 25, 27, and 32 to N, O, and S. The old values are NMR1, OMR1, and Sv2.

Open Bits AI session

🤖 Datadog Autotest · Commit c2221fc · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 13, 2026

Copy link
Copy Markdown

Test Environment - spring_boot

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 14.71 16.04 $\color{green}{\blacktriangledown}$ -1.33 16.36 $\color{green}{\blacktriangledown}$ -1.65 24/91
agentless 7.26 9.54 $\color{green}{\blacktriangledown}$ -2.28 9.92 $\color{green}{\blacktriangledown}$ -2.66 22/89
agentlessCodeCoverage 10.61 13.40 $\color{green}{\blacktriangledown}$ -2.79 13.40 $\color{green}{\blacktriangledown}$ -2.79 22/89
agentlessLineCoverage 24.26 22.09 $\color{red}{\blacktriangle}$ +2.17 22.09 $\color{red}{\blacktriangle}$ +2.17 21/87

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 13, 2026

Copy link
Copy Markdown

Test Environment - sonar-java

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent -8.04 11.65 $\color{green}{\blacktriangledown}$ -19.69 12.12 $\color{green}{\blacktriangledown}$ -20.16 27/104
agentless 22.57 11.65 $\color{red}{\blacktriangle}$ +10.92 11.65 $\color{red}{\blacktriangle}$ +10.92 27/104
agentlessCodeCoverage 78.69 74.82 $\color{red}{\blacktriangle}$ +3.87 74.82 $\color{red}{\blacktriangle}$ +3.87 27/104
agentlessLineCoverage 122.71 111.62 $\color{red}{\blacktriangle}$ +11.09 111.62 $\color{red}{\blacktriangle}$ +11.09 27/104

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant