Skip to content

Misc CI fixes - #4219

Draft
cataphract wants to merge 39 commits into
masterfrom
glopes/ci-misc
Draft

cataphract wants to merge 39 commits into
masterfrom
glopes/ci-misc

Conversation

@cataphract

Copy link
Copy Markdown
Contributor

Description

For the most part still unreviewed AI changes. Wait to leave draft state for review

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 19, 2026

Copy link
Copy Markdown

Pipelines  Tests

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 6 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | test_integrations_frankenphp: [8.5] — ❌ 1 test failed

View more details · View in GitLab

❌ DDTrace\Tests\Integrations\Frankenphp\CommonScenariosTest::testScenario from frankenphp-test.DDTrace\Tests\Integrations\Frankenphp\CommonScenariosTest
DDTrace\Tests\Integrations\Frankenphp\CommonScenariosTest::testScenario
Exception: install-frankenphp.sh failed (exit 1):
go: downloading github.com/google/s2a-go v0.1.9
go: downloading github.com/bits-and-blooms/bitset v1.24.6
go: downloading github.com/mschoch/smat v0.2.0
/home/circleci/go/pkg/mod/github.com/googleapis/gax-go/v2@v2.22.0/telemetry.go:43:2: go.opentelemetry.io/otel@v1.45.0: read "https://proxy.golang.org/go.opentelemetry.io/otel/@v/v1.45.0.zip": stream error: stream ID 105; INTERNAL_ERROR; received from peer
/home/circleci/go/pkg/mod/github.com/googleapis/gax-go/v2@v2.22.0/telemetry.go:44:2: go.opentelemetry.io/otel@v1.45.0: read "https://proxy.golang.org/go.opentelemetry.io/otel/@v/v1.45.0.zip": stream error: stream ID 105; INTERNAL_ERROR; received from peer
/home/circleci/go/pkg/mod/github.com/googleapis/gax-go/v2@v2.22.0/telemetry.go:45:2: go.opentelemetry.io/otel@v1.45.0: read "https://proxy.golang.org/go.opentelemetry.io/otel/@v/v1.45.0.zip": stream error: stream ID 105; INTERNAL_ERROR; received from peer
/home/circleci/go/pkg/mod/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.69.0/internal/semconv/client.go:21:2: go.opentelemetry.io/otel@v1.45.0: read "https://proxy.golang.org/go.opentelemetry.io/otel/@v/v1.45.0.zip": stream error: stream ID 105; INTERNAL_ERROR; received from peer
/home/circleci/go/pkg/mod/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.69.0/internal/semconv/client.go:23:2: go.opentelemetry.io/otel@v1.45.0: read "https://proxy.golang.org/go.opentelemetry.io/otel/@v/v1.45.0.zip": stream error: stream ID 105; INTERNAL_ERROR; received from peer
...
DataDog/apm-reliability/dd-trace-php | PHP Language Tests: [7.1] — 🔄 Retry may pass, looks flaky

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | test_web_cakephp_latest: [8.1, apache2handler] — 🔄 Retry may pass, looks flaky

View more details · View in GitLab

View all 6 failed jobs.

⚠️ Warnings

1 Test performance regression detected

Test New execution time Base Execution time Increase DataDog link
testScenarioGetWithView
from laravel-11x-test.DDTrace\Tests\Integrations\Laravel\V11_x\CommonScenariosTest
3.48s 524.697657ms +2.95s (+563%) View in Datadog

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 68.24% (-0.04%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f1ce464 | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Sep 19, 2026

Copy link
Copy Markdown

Benchmarks [ profiler ]

Benchmark execution time: 2026-09-21 14:14:57

Comparing candidate commit f1ce464 in PR branch glopes/ci-misc with baseline commit 05e7216 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@pr-commenter

pr-commenter Bot commented Sep 19, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-09-21 15:06:08

Comparing candidate commit f1ce464 in PR branch glopes/ci-misc with baseline commit 05e7216 in branch master.

Found 2 performance improvements and 4 performance regressions! Performance is the same for 187 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-5.394µs; -3.086µs] or [-4.548%; -2.602%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-6.395µs; -5.125µs] or [-5.444%; -4.363%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+51.597ns; +148.003ns] or [+3.440%; +9.866%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+75.869ns; +146.731ns] or [+5.145%; +9.951%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+54.875ns; +151.125ns] or [+3.680%; +10.134%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+51.431ns; +106.569ns] or [+3.439%; +7.125%]

@cataphract
cataphract force-pushed the glopes/ci-misc branch 2 times, most recently from b982f4f to 402cb5a Compare September 21, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant