-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Minor fixes to OTLP collector page #39293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asopkin
wants to merge
5
commits into
master
Choose a base branch
from
asopkin/pure-otlp-pipeline-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−31
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
584c76b
Minor fixes to OTLP collector page
asopkin 2b885ce
Update hugo/content/en/opentelemetry/setup/collector_exporter/pure_ot…
asopkin 93dd7f1
Update hugo/content/en/opentelemetry/setup/collector_exporter/pure_ot…
asopkin 0136387
Update hugo/content/en/opentelemetry/setup/collector_exporter/pure_ot…
asopkin b1e6e41
Changes from review feedback
asopkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: The title (and description at L7) now use "Pure OpenTelemetry Collector", but the body still says "Community" in several places that were left unchanged:
dd-otel-metric-config): "The recommended Community OTel Collector configuration uses..."If the rename is intentional, please update these occurrences (and coordinate the corresponding heading rename in
hugo/content/en/opentelemetry/compatibility.md, which still uses "OTel SDK + Community OTel Collector" — otherwise the L36 link anchor breaks) so the naming is consistent.