feat(libdatadog): add universal core and optional extras packages - #207
feat(libdatadog): add universal core and optional extras packages#207rochdev wants to merge 5 commits into
Conversation
c77f5ff to
d12e121
Compare
|
|
||
| #[wasm_bindgen] | ||
| pub fn set_envp(&mut self, envp: Box<[JsValue]>) -> Result<(), JsValue> { | ||
| pub fn set_envp(&mut self, envp: Vec<JsValue>) -> Result<(), JsValue> { |
There was a problem hiding this comment.
This file seems mostly like stylistic changes, still.
There was a problem hiding this comment.
All changes to this file have been reverted.
| @@ -0,0 +1,37 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
This is a test, not a script. Add it to the tests directory.
| @@ -0,0 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
A little weird that this file is bash and clean-native is JS. Try to be consistent here.
Overall package sizeSelf size: 36.97 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
d12e121 to
c0fa67d
Compare
| @@ -0,0 +1,10 @@ | |||
| export function backend(): 'native' | 'wasm' | |||
There was a problem hiding this comment.
Is there a test to verify this file?
| @@ -0,0 +1,66 @@ | |||
| { | |||
| "name": "@datadog/libdatadog", | |||
| "version": "0.1.0-pre", | |||
There was a problem hiding this comment.
Note that we already have this package published, so this number may need to be bumped.
There was a problem hiding this comment.
This is already done in release PRs.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@datadog/libdatadog", | |||
| "name": "@datadog/libdatadog-extras", | |||
There was a problem hiding this comment.
Add a TODO somewhere to restructure this whole package Russian doll situation.
There was a problem hiding this comment.
Done, although it's in a bit of a random place because JSON don't have TODOs.
a9fb52c to
e2b5753
Compare
|
@bengl All your concerns should have been addressed. I also improved the packaging and cross-platform testing. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2b5753847
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
bb617cd to
01ad475
Compare
2 participants
Summary
Introduces the package foundation shared by the rest of the stack:
@datadog/libdatadogis the universal native-first package with an alwaysavailable inlined WASM fallback.
@datadog/libdatadog-extrasis the renamed existing package for optionalfunctionality that is not supported in every environment.
The universal artifact combines the existing DDSketch and compression
bindings into one native library and one WASM module. The APM data pipeline is
deliberately excluded here and added by the next PR in the stack.
Details
of the universal metapackage.
cross-platform compatibility.
the forced-WASM subpath.
supported by Node.js 18; the broader
--all-featuresmode can emit GCinstructions that Node.js 18 cannot parse.
wasm-pack0.14 in build and release CI to remain compatible with therepository's Rust 1.90 toolchain.
extras package from the same release workflow.
library_configin extras; its Rust changes are limited to dependencycleanup and edits required by Clippy.
The generated
packages/libdatadog/package-lock.jsonaccounts for most of theadded lines in this foundation PR.
Validation
tracker coverage.
library_configtest.This PR was generated by Codex.
Stack created with GitHub Stacks CLI • Give Feedback 💬