feat(trace-utils): add v1-native agentless JSON encoder brick by anais-raison · Pull Request #2370 · DataDog/libdatadog

anais-raison · 2026-08-19T13:36:20Z

What does this PR do?

Adds a v1-native equivalent of the existing v0.4 agentless JSON encoder, as groundwork for making v1::Span/v1::TraceChunk the exporter's canonical internal type:

agentless_encoder::encode_payload_from_v1 and its helpers (collect_attrs_v1, flatten_attr_into_v1, encode_span_link_v1, encode_span_event_v1) (libdd-trace-utils)

Nothing is wired into the live pipeline yet.

Motivation

Part of APMSP-2812: migration of the exporter from v0.4 to v1 with isolated bricks first before one final breaking PR that will handle the actual swap.

Additional Notes

Pure addition, no behavior change — these functions aren't called anywhere yet, so there's no regression risk.

Isolated brick for APMSP-2812: adds encode_payload_from_v1 and its v1::Span-native helpers (collect_attrs_v1, flatten_attr_into_v1, encode_span_link_v1, encode_span_event_v1) alongside the existing v0.4 agentless encoder. Not wired into any live send path yet.

datadog-datadog-us1-prod · 2026-08-19T13:40:59Z

✅ All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 97.02%
• Overall Coverage: 77.25% (+0.17%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 85d57f5 | Docs | View more details | Give us feedback!}

pr-commenter · 2026-08-19T14:04:16Z

Benchmarks

Comparison

Benchmark execution time: 2026-09-07 12:10:14

Comparing candidate commit db618ba in PR branch anais/v1-agentless-encoder-brick with baseline commit 64ad2ed in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 5 performance regressions! Performance is the same for 70 metrics, 10 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:glob_matcher/ascii_case_insensitive_match/wall_time

🟥 execution_time [+1.919ns; +1.950ns] or [+7.192%; +7.306%]

scenario:glob_matcher/ascii_exact_match/wall_time

🟥 execution_time [+1.590ns; +1.618ns] or [+5.882%; +5.986%]

scenario:glob_matcher/ascii_exact_miss/wall_time

🟥 execution_time [+1.467ns; +1.501ns] or [+12.391%; +12.683%]

scenario:trace_buffer/2_senders/no_delay

🟥 execution_time [+154.622µs; +170.164µs] or [+9.469%; +10.421%]
🟥 throughput [-104569.928op/s; -95003.354op/s] or [-9.481%; -8.613%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:datadog_sample_span/parent_not_sampled_short_circuit/allocated_bytes

unstable execution_time [-0.000ns; +0.000ns] or [+514.848%; -514.855%]

scenario:datadog_sample_span/parent_sampled_short_circuit/allocated_bytes

unstable execution_time [-0.000ns; +0.000ns] or [+514.821%; -514.844%]

scenario:glob_matcher/ascii_case_insensitive_match/allocated_bytes

unstable execution_time [-0.000ns; +0.000ns] or [+536.188%; -524.377%]

scenario:glob_matcher/ascii_exact_match/allocated_bytes

unstable execution_time [-0.000ns; +0.000ns] or [+531.328%; -522.188%]

scenario:glob_matcher/ascii_exact_miss/allocated_bytes

unstable execution_time [-0.000ns; +0.000ns] or [+566.064%; -538.072%]

scenario:glob_matcher/ascii_wildcard_backtrack_match/allocated_bytes

unstable execution_time [-0.000ns; +0.000ns] or [+513.853%; -514.417%]

scenario:glob_matcher/ascii_wildcard_heavy_backtrack/allocated_bytes

unstable execution_time [-0.000ns; +0.000ns] or [+514.508%; -514.706%]

scenario:glob_matcher/ascii_wildcard_question_match/allocated_bytes

unstable execution_time [-0.000ns; +0.000ns] or [+513.695%; -514.348%]

scenario:glob_matcher/ascii_wildcard_star_match/allocated_bytes

unstable execution_time [-0.000ns; +0.000ns] or [+513.220%; -514.139%]

scenario:glob_matcher/star_short_circuit/allocated_bytes

unstable execution_time [-0.000ns; +0.000ns] or [+514.903%; -514.880%]

Candidate

Omitted due to size.

Baseline

Omitted due to size.

dd-octo-sts · 2026-08-19T14:05:30Z

Artifact Size Benchmark Report

aarch64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so	8.45 MB	8.45 MB	0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a	91.32 MB	91.32 MB	+0% (+8 B) 👌

aarch64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so	11.38 MB	11.38 MB	0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a	102.61 MB	102.61 MB	0% (0 B) 👌

libdatadog-x64-windows

Artifact	Baseline	Commit	Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll	27.32 MB	27.32 MB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib	96.08 KB	96.08 KB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb	185.41 MB	185.40 MB	-0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib	803.94 MB	804.08 MB	+.01% (+141.70 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll	9.00 MB	9.00 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib	96.08 KB	96.08 KB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb	26.20 MB	26.20 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib	52.21 MB	52.21 MB	0% (0 B) 👌

libdatadog-x86-windows

Artifact	Baseline	Commit	Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll	23.82 MB	23.82 MB	+0% (+512 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib	97.58 KB	97.58 KB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb	190.44 MB	190.44 MB	+0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib	786.99 MB	787.03 MB	+0% (+42.13 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll	6.96 MB	6.96 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib	97.58 KB	97.58 KB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb	28.18 MB	28.18 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib	49.70 MB	49.70 MB	0% (0 B) 👌

x86_64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a	81.48 MB	81.48 MB	+0% (+8 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so	9.41 MB	9.41 MB	0% (0 B) 👌

x86_64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a	97.21 MB	97.21 MB	+0% (+8 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so	11.46 MB	11.46 MB	0% (0 B) 👌

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1fbc4b65b4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

github-actions Bot added the mini-agent label Aug 19, 2026

anais-raison self-assigned this Aug 19, 2026

anais-raison and others added 2 commits August 20, 2026 13:24

Merge branch 'main' into anais/v1-agentless-encoder-brick

87fe6da

fix: cargo

1a854a5

paullegranddc reviewed Aug 20, 2026

View reviewed changes

anais-raison and others added 3 commits August 26, 2026 13:42

Merge branch 'main' into anais/v1-agentless-encoder-brick

4448ff3

fix: comments

55573a5

fix: comments

1fbc4b6

anais-raison marked this pull request as ready for review August 28, 2026 13:19

anais-raison requested review from a team as code owners August 28, 2026 13:19

Merge branch 'main' into anais/v1-agentless-encoder-brick

ec1bf49

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread libdd-trace-utils/src/agentless_encoder/mod.rs Outdated

Comment thread libdd-trace-utils/src/agentless_encoder/mod.rs

yannham approved these changes Sep 2, 2026

View reviewed changes

anais-raison and others added 4 commits September 2, 2026 14:57

fix: codex comment

3a1006c

fix: comments

7d3deb7

fix: comments

db618ba

Merge branch 'main' into anais/v1-agentless-encoder-brick

85d57f5

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: waiting mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: waiting mergequeue-status: queued labels Sep 7, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit b15bd22 into main Sep 7, 2026
123 checks passed

gh-worker-dd-devflow-36fce6 Bot removed the mergequeue-status: in_progress label Sep 7, 2026

gh-worker-dd-mergequeue-cf854d Bot deleted the anais/v1-agentless-encoder-brick branch September 7, 2026 12:59

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: done label Sep 7, 2026

Uh oh!

Conversation

anais-raison commented Aug 19, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Uh oh!

datadog-datadog-us1-prod Bot commented Aug 19, 2026 • edited by datadog-official Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Comparison

Explanation

More details about the CI and significant changes

scenario:glob_matcher/ascii_case_insensitive_match/wall_time

scenario:glob_matcher/ascii_exact_match/wall_time

scenario:glob_matcher/ascii_exact_miss/wall_time

scenario:trace_buffer/2_senders/no_delay

Unstable benchmarks

scenario:datadog_sample_span/parent_not_sampled_short_circuit/allocated_bytes

scenario:datadog_sample_span/parent_sampled_short_circuit/allocated_bytes

scenario:glob_matcher/ascii_case_insensitive_match/allocated_bytes

scenario:glob_matcher/ascii_exact_match/allocated_bytes

scenario:glob_matcher/ascii_exact_miss/allocated_bytes

scenario:glob_matcher/ascii_wildcard_backtrack_match/allocated_bytes

scenario:glob_matcher/ascii_wildcard_heavy_backtrack/allocated_bytes

scenario:glob_matcher/ascii_wildcard_question_match/allocated_bytes

scenario:glob_matcher/ascii_wildcard_star_match/allocated_bytes

scenario:glob_matcher/star_short_circuit/allocated_bytes

Candidate

Baseline

Uh oh!

dd-octo-sts Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Artifact Size Benchmark Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anais-raison commented Aug 19, 2026 •

edited by atlassian Bot

Loading

datadog-datadog-us1-prod Bot commented Aug 19, 2026 •

edited by datadog-official Bot

Loading

pr-commenter Bot commented Aug 19, 2026 •

edited

Loading

dd-octo-sts Bot commented Aug 19, 2026 •

edited

Loading