test(debugger): accept flat dotted dd.trace_id in correlation gate - #7572
Open
p-datadog wants to merge 1 commit into
Open
test(debugger): accept flat dotted dd.trace_id in correlation gate#7572p-datadog wants to merge 1 commit into
p-datadog wants to merge 1 commit into
Conversation
The coordinated-sampling gate reads dd.trace_id to group snapshots by
trace. The Ruby tracer emits it as a flat dotted key at the envelope
root ("dd.trace_id"), matching the Java/.NET/Go dotted-key convention,
while Python/Node/Ruby nest it under a dd object. The test read the
nested form only, so dotted-key snapshots resolved to None and failed
the presence assertion before any sampling logic ran.
Read both shapes, mirroring the dual-shape lookup already used for
dd.span_id in test_debugger_exception_replay.py.
Scope: the reported feature-564 test only. runtime_id (camelCase) and
the generation token remain nested/absent and stay out of scope.
|
🔄 Datadog auto-retried 4 jobs - 1 passed on retry 🔗 Commit SHA: e3da2e0 | Docs | View more details | Give us feedback! |
p-datadog
marked this pull request as ready for review
September 4, 2026 22:30
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
grantseltzer
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Stacked on #7425, which introduces the feature-564 test
Test_Debugger_Coordinated_Sampling. The test groups snapshots by trace usingdd.trace_idand read only the nested form under theddobject. The Ruby tracer (DataDog/dd-trace-rb#6118) emitsdd.trace_idas a flat dotted key at the envelope root, matching the Java/.NET/Go convention, so dotted-key snapshots resolved toNoneand failed the presence assertion before any sampling logic ran.Changes
Read
dd.trace_idfrom both the nestedddobject and the flat dotted key: